Skip to content

Incorrect summary comments on Warn.If overloads #3811

Closed

Description

@rouacke

I believe a couple Warn.If overloads have incorrect summary comments.

https://github.com/nunit/nunit/blob/master/src/NUnitFramework/framework/Warn.cs#L335

https://github.com/nunit/nunit/blob/master/src/NUnitFramework/framework/Warn.cs#L335

The summary comments on those overloads read:

Asserts that a condition is true. If the condition is false, a warning is issued.

However, the method bodies read:

Warn.If(condition, Is.True, ...);

They log a warning if the condition is true.

The summary comment seems to be correct on other overloads:

Asserts that a condition is false. If the condition is true a warning is issued.

Activity

  1. rprouse commented on Apr 8, 2021

    @rprouse
    Member

    Good catch. That code has been there forever. It is surprising no one has noticed before you!

  2. added this to the 4.0 milestone on Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      ⌂ 换网址