Skip to content

use diagnostic positions in exceptions - #4585

Merged
nlohmann merged 21 commits into
nlohmann:developfrom
hnampally:develop
Jan 19, 2025
Merged

nlohmann merged 21 commits into
nlohmann:developfrom
hnampally:develop

Conversation

@hnampally

Copy link
Copy Markdown
Contributor

This PR is for #4561, updates the diagnostics function in the exceptions.hpp to use diagnostic positions in exceptions.


Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

Signed-off-by: Harinath Nampally <harinath922@gmail.com>
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
@coveralls

coveralls commented Jan 7, 2025 •

Copy link
Copy Markdown

Coverage Status

coverage: 99.186% (+0.001%) from 99.185%
when pulling 5c22738 on hnampally:develop
into bdb8d2b on nlohmann:develop.

Signed-off-by: Harinath Nampally <harinath922@gmail.com>
Comment thread include/nlohmann/detail/exceptions.hpp Resolved
Comment thread include/nlohmann/detail/exceptions.hpp Resolved
Comment thread include/nlohmann/detail/exceptions.hpp Resolved
Comment thread tests/src/unit-json_patch.cpp Resolved
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
Comment thread include/nlohmann/detail/exceptions.hpp Resolved
Comment thread tests/src/unit-diagnostic-positions.cpp Resolved
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
@nlohmann nlohmann mentioned this pull request Jan 9, 2025
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
@nlohmann

Copy link
Copy Markdown
Owner

The coverage job is now fixed in the develop branch. Please update.

@nlohmann nlohmann added the please rebase Please rebase your branch to origin/develop label Jan 15, 2025
@nlohmann nlohmann removed the please rebase Please rebase your branch to origin/develop label Jan 17, 2025
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
@nlohmann

Copy link
Copy Markdown
Owner

There is a problem building the documentation:

Error reading page 'api/macros/json_diagnostic_positions.md': Snippet at path 'examples/diagnostic_positions_exception.cpp' could not be found

Pleae check if you can build the documentation locally.

@hnampally
hnampally requested a review from nlohmann January 18, 2025 20:59
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
@nlohmann nlohmann linked an issue Jan 18, 2025 that may be closed by this pull request

@nlohmann nlohmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.4 milestone Jan 18, 2025
@nlohmann
nlohmann merged commit d23291b into nlohmann:develop Jan 19, 2025
@nlohmann

Copy link
Copy Markdown
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use diagnostic positions in exceptions

5 participants

⌂ 换网址