Skip to content

Add CPack support - #4459

Merged
nlohmann merged 1 commit into
nlohmann:developfrom
zjyhjqs:feat/cpack-support
Nov 16, 2024
Merged

nlohmann merged 1 commit into
nlohmann:developfrom
zjyhjqs:feat/cpack-support

Conversation

@zjyhjqs

@zjyhjqs zjyhjqs commented Sep 17, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@zjyhjqs
zjyhjqs requested a review from nlohmann as a code owner September 17, 2024 08:26
@request-info

request-info Bot commented Sep 17, 2024

Copy link
Copy Markdown

We would appreciate it if you could provide us with more info about this issue or pull request! Please check the issue template and the pull request template.

@request-info request-info Bot added the state: needs more info the author of the issue needs to provide more details label Sep 17, 2024
@zjyhjqs

zjyhjqs commented Nov 14, 2024

Copy link
Copy Markdown
Contributor Author

@nlohmann Do you have question about this PR?

@nlohmann

Copy link
Copy Markdown
Owner

@nlohmann Do you have question about this PR?

Why is this addition needed?

@zjyhjqs

zjyhjqs commented Nov 15, 2024

Copy link
Copy Markdown
Contributor Author

Why is this addition needed?

The CPack module is necessary for users to use CPack to package the library. (The main information required by cpack is provided by project(). Just including the CPack module is enough.)

@nlohmann nlohmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.4 milestone Nov 16, 2024
@nlohmann
nlohmann merged commit fd20975 into nlohmann:develop Nov 16, 2024
slowriot pushed a commit to slowriot/json that referenced this pull request Jan 10, 2025
@zjyhjqs
zjyhjqs deleted the feat/cpack-support branch March 17, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake S state: needs more info the author of the issue needs to provide more details

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址