Skip to content

fix cmake header path in install with custom CMAKE_INSTALL_INCLUDEDIR - #4194

Merged
nlohmann merged 1 commit into
nlohmann:developfrom
bebuch:patch-1
Oct 31, 2023
Merged

fix cmake header path in install with custom CMAKE_INSTALL_INCLUDEDIR#4194
nlohmann merged 1 commit into
nlohmann:developfrom
bebuch:patch-1

Conversation

@bebuch

@bebuch bebuch commented Oct 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

@bebuch
bebuch requested a review from nlohmann as a code owner October 30, 2023 17:48
@coveralls

coveralls commented Oct 30, 2023

Copy link
Copy Markdown

Coverage Status

coverage: 100.0%. remained the same when pulling 4ec42c9 on bebuch:patch-1 into 58d6aa5 on nlohmann:develop.

@bebuch

bebuch commented Oct 31, 2023

Copy link
Copy Markdown
Contributor Author

I don't understand how the CI error is connected to my PR. Please tell me if I need to change something.

@nlohmann

nlohmann commented Oct 31, 2023

Copy link
Copy Markdown
Owner

You're right, this is unrelated.

@nlohmann nlohmann added this to the Release 3.11.3 milestone Oct 31, 2023
nlohmann
nlohmann approved these changes Oct 31, 2023
View reviewed changes

@nlohmann nlohmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann
nlohmann merged commit cdb2906 into nlohmann:develop Oct 31, 2023
@nlohmann

nlohmann commented Oct 31, 2023

Copy link
Copy Markdown
Owner

Thanks!

@nlohmann nlohmann mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

No one assigned

Labels

CMake S

Projects

None yet

Milestone

Release 3.11.3

Development

Successfully merging this pull request may close these issues.

3 participants

@bebuch @coveralls @nlohmann
⌂ 换网址