Repository navigation
Make json_pointer usable as map key (again) - #3685
Merged
nlohmann merged 2 commits intoAug 7, 2022
Merged
Conversation
falbrechtskirchinger
force-pushed
the
json_pointer-map-key
branch
3 times, most recently
from
August 7, 2022 09:02
0e303f8 to
aecfa16
Compare
falbrechtskirchinger
force-pushed
the
json_pointer-map-key
branch
from
August 7, 2022 09:04
aecfa16 to
504acef
Compare
falbrechtskirchinger
left a comment
falbrechtskirchinger
left a comment
Contributor
Author
There was a problem hiding this comment.
Looks good to me.
falbrechtskirchinger
marked this pull request as ready for review
August 7, 2022 09:05
Owner
What do you mean by that? |
falbrechtskirchinger
changed the title
Contributor
Author
|
I want to add the other operators (>, <=, >=) and will do the documentation then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
operator<(json_pointer, json_pointer)andoperator<=>(json_pointer)(C++20) to makejson_pointerusable as a map key.Documentation deferred to when the remaining operators are added.
Closes #3680.
To Do: