Repository navigation
Fix -Wignored-reference-qualifiers - #3677
Closed
georgthegreat wants to merge 1 commit into
Closed
georgthegreat wants to merge 1 commit into
georgthegreat wants to merge 1 commit into
Conversation
In certain STLs, `std::vector<bool>::reference` is just `bool&`. Prepending `const` causes the following warning: ``` include/nlohmann/detail/conversions/to_json.hpp:271:42: error: 'const' qualifier on reference type 'std::vector<bool>::reference' (aka 'bool &') has no effect [-Werror,-Wignored-reference-qualifiers] ``` This PR fixes the problem.
Contributor
|
Which STL would that be? ( So we can test.) |
Author
|
We use custom STL with std::vector compation disabled. |
Contributor
|
I see. I did fix it slightly differently (#3678). We can simply disable the |
shaischaudhry
approved these changes
Aug 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain STLs,
std::vector<bool>::referenceis justbool&.Prepending
constcauses the following warning:This PR fixes the problem.
[Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.]
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmanndirectory, runmake amalgamateto create the single-header filesingle_include/nlohmann/json.hpp. The whole process is described here.Please don't
#ifdefs or other means.