Skip to content

Add Discord badge to README - #3651

Merged
nlohmann merged 1 commit into
nlohmann:developfrom
falbrechtskirchinger:discord
Aug 3, 2022
Merged

nlohmann merged 1 commit into
nlohmann:developfrom
falbrechtskirchinger:discord

Conversation

@falbrechtskirchinger

Copy link
Copy Markdown
Contributor

Add the Shields.io Discord badge with a permanent invite link to the README.

To use the Discord badge a Discord server admin must enable the widget setting on the server.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 530bdcb on falbrechtskirchinger:discord into df98ca2 on nlohmann:develop.

@nlohmann

nlohmann commented Aug 2, 2022

Copy link
Copy Markdown
Owner

I think we should make clear that Discord will not be a support channel, but a means to coordinate the development. A badge is fine, but this should also go to the README.

@nlohmann

nlohmann commented Aug 2, 2022

Copy link
Copy Markdown
Owner

FYI: Enabled the widget in the server settings.

@nlohmann nlohmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mention in https://github.com/nlohmann/json#support that the Discord channel is to coordinate library development and not meant as a means to provide support.

@falbrechtskirchinger

Copy link
Copy Markdown
Contributor Author

If the server starts attracting a healthy number of people, I don't see why we couldn't add a dedicated support channel?

@nlohmann

nlohmann commented Aug 3, 2022

Copy link
Copy Markdown
Owner

If the server starts attracting a healthy number of people, I don't see why we couldn't add a dedicated support channel?

I am hesitant, because I still get a lot of emails from people asking support, and I stopped answering (and only referred them to GitHub), because such a 1:1 communication has no benefit to others.

Let's just see what happens now, and we can still change our policy later.

@nlohmann nlohmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.2 milestone Aug 3, 2022
@nlohmann
nlohmann merged commit 2ac7d02 into nlohmann:develop Aug 3, 2022
@falbrechtskirchinger
falbrechtskirchinger deleted the discord branch August 3, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址