Repository navigation
Re-add value_type detection to distinguish string types - #3604
Merged
nlohmann merged 2 commits intoJul 28, 2022
Merged
Conversation
falbrechtskirchinger
marked this pull request as draft
July 23, 2022 20:30
falbrechtskirchinger
changed the title
falbrechtskirchinger
marked this pull request as ready for review
July 24, 2022 05:47
falbrechtskirchinger
marked this pull request as draft
July 27, 2022 05:33
Contributor
Author
|
Not too happy with this band-aid; will try a different approach. Edit: Nevermind. |
falbrechtskirchinger
marked this pull request as ready for review
July 27, 2022 06:52
This was referenced Jul 29, 2022
Closed
nlohmann
added a commit
that referenced
this pull request
Oct 4, 2026
* Add regression test for converting json to std::variant<json> (#5066) With 3.10.5, get<std::variant<json>>() was well-formed through the string from_json overload, so the implicit conversion operator was a candidate when converting json to std::variant<json>, and MSVC picked it over the variant's converting constructor. The tightened constraints from #3427 and #3604 (3.11.0) removed that path; this test guards against regressions. Signed-off-by: Niels Lohmann <mail@nlohmann.me> * Fix clang-tidy and clang 6 in the #5066 regression test ci_clang_tidy asked for emplace_back instead of push_back. The push_back is the point of the test: #5066 is about the implicit conversion from json to the vector's value type, which emplace_back would bypass. Silence the check on that line. clang 5 and 6 cannot instantiate std::variant<json> from libstdc++ 10's <variant> ("cannot cast private base class"), which broke ci_test_compilers_clang (6). Tested with the CI images: clang 7 to 11 compile and pass, including clang 11 with libstdc++ 10. Skip the runtime check for clang before 7; the static_assert still runs. Signed-off-by: Niels Lohmann <mail@nlohmann.me> --------- Signed-off-by: Niels Lohmann <mail@nlohmann.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-add the detection of a
value_typemember to theis_constructible_string_typetype trait.Fixes #3602.