Skip to content

CI: fix "JSON_MultipleHeaders" option spelling - #3555

Merged
nlohmann merged 1 commit into
nlohmann:developfrom
karzhenkov:fix-ci_test_single_header
Jun 25, 2022
Merged

nlohmann merged 1 commit into
nlohmann:developfrom
karzhenkov:fix-ci_test_single_header

Conversation

@karzhenkov

@karzhenkov karzhenkov commented Jun 25, 2022 •

Copy link
Copy Markdown
Contributor

Due to a typo, the test ci_test_single_header uses actually multiple headers.

@karzhenkov
karzhenkov requested a review from nlohmann as a code owner June 25, 2022 08:25
@request-info

request-info Bot commented Jun 25, 2022

Copy link
Copy Markdown

We would appreciate it if you could provide us with more info about this issue or pull request! Please check the issue template and the pull request template.

@request-info request-info Bot added the state: needs more info the author of the issue needs to provide more details label Jun 25, 2022

@falbrechtskirchinger falbrechtskirchinger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 648d47a on karzhenkov:fix-ci_test_single_header into 39e2768 on nlohmann:develop.

@nlohmann nlohmann removed the state: needs more info the author of the issue needs to provide more details label Jun 25, 2022

@nlohmann nlohmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.0 milestone Jun 25, 2022
@nlohmann nlohmann self-assigned this Jun 25, 2022
@nlohmann
nlohmann merged commit 954b10a into nlohmann:develop Jun 25, 2022
@nlohmann

Copy link
Copy Markdown
Owner

Thanks! Good catch indeed!

@karzhenkov
karzhenkov deleted the fix-ci_test_single_header branch June 25, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

⌂ 换网址