Repository navigation
Use std::iterator_traits to extract iterator_category - #3544
Merged
Merged
Conversation
In third-party STL implementations, `array_t::iterator` might be a pointer (e.g., `vector` in [EASTL](https://github.com/electronicarts/EASTL)) rather than a class, in which case directly using `array_t::iterator::iterator_category` is invalid. This commit fixes it with `std::iterator_traits`, which handles pointers correctly.
nlohmann
requested changes
Jun 18, 2022
nlohmann
left a comment
nlohmann
left a comment
Owner
There was a problem hiding this comment.
Please run make amalgamate to also add the changes to the single-header version, single_include/json.hpp.
Contributor
Author
Thanks for the instructions. Should be good now. |
falbrechtskirchinger
approved these changes
Jun 18, 2022
falbrechtskirchinger
left a comment
falbrechtskirchinger
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In third-party STL implementations,
array_t::iteratormight be a pointer (e.g.,vectorin EASTL) rather than a class, in which case directly usingarray_t::iterator::iterator_categoryis invalid. This commit fixes it withstd::iterator_traits, which handles pointers correctly.