Skip to content

Handle invalid BJData optimized type, fix #3461 - #3463

Merged
nlohmann merged 2 commits into
nlohmann:developfrom
NeuroJSON:fix3461
May 1, 2022
Merged

nlohmann merged 2 commits into
nlohmann:developfrom
NeuroJSON:fix3461

Conversation

@fangq

@fangq fangq commented May 1, 2022

Copy link
Copy Markdown
Contributor

This patch should fix #3461. Tested both with the fuzzer unit and the unit-test.

@fangq
fangq requested a review from nlohmann as a code owner May 1, 2022 02:18
@nlohmann

nlohmann commented May 1, 2022

Copy link
Copy Markdown
Owner

Please update to the latest develop branch (we renamed some folders in #3462).

@nlohmann nlohmann added the please rebase Please rebase your branch to origin/develop label May 1, 2022
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 96bf143 on NeuroJSON:fix3461 into 0c698b7 on nlohmann:develop.

@falbrechtskirchinger falbrechtskirchinger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One potential issue. Looks good otherwise.

@nlohmann nlohmann mentioned this pull request May 1, 2022
3 tasks done
@nlohmann nlohmann added aspect: binary formats BSON, CBOR, MessagePack, UBJSON release item: 🐛 bug fix and removed please rebase Please rebase your branch to origin/develop labels May 1, 2022

@nlohmann nlohmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this May 1, 2022
@nlohmann nlohmann added this to the Release 3.11.0 milestone May 1, 2022
@nlohmann
nlohmann merged commit b205361 into nlohmann:develop May 1, 2022
@nlohmann

nlohmann commented May 1, 2022

Copy link
Copy Markdown
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

json:parse_bjdata_fuzzer reaches assertion

4 participants

⌂ 换网址