Repository navigation
CI: windows-2016 has been deprecated; remove jobs - #3416
Merged
Merged
Conversation
nlohmann
removed their request for review
April 4, 2022 05:14
nlohmann
requested changes
Apr 4, 2022
nlohmann
left a comment
nlohmann
left a comment
Owner
There was a problem hiding this comment.
Can you please also update the README section and remove the lines for MSVC 2017?
falbrechtskirchinger
force-pushed
the
drop-windows-2016
branch
from
April 4, 2022 07:07
1d33c5e to
9d11f0a
Compare
Contributor
Author
|
Done. The compiler list in README needs a thorough update at some point. GCC 11 (experimental) doesn't seem right, for example. |
Owner
|
Thanks! |
Owner
Fixed in #3420. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As previously mentioned windows-2016 is now deprecated. Remove msvc2017* jobs from the workflow.
GH offers no replacement for jobs requiring "Visual Studio 15 2017".