Repository navigation
pattern: wrong results for /**foo #1149
Description
While working on #1147 I think I noticed that the regexp generated for /**foo is incorrect.
https://go.dev/play/p/XXoRQ4EdBwV is some go code that matches /**foo against a number of paths; as you can see all three match.
Here's a bash shell in a container testing the same three paths:
$ echo $BASH_VERSION
5.2.15(1)-release
$ touch /foo
$ mkdir -p /a/b/c
$ touch /a/b/cfoo
$ touch /a/b/c/foo
$ ls /**foo
/foo
Bash only matches /foo, the pattern package matches all three paths. Is this a bug or am I missing something?
Activity
mvdan commentedon Apr 8, 2025
We aim to emulate Bash behavior as closely as possible within reason, so this is likely a bug. The recursive globbing logic is surprisingly difficult to get exactly right. Happy to review a patch, otherwise I'll look at this sometime this week.
pattern: add more test cases for globstar not used on its own
mvdan commentedon Apr 13, 2025
This should be fixed now. See the commit adding test cases; this wasn't a bug in the
interporexpandpackages. It was only a bug when using thepatternpackage directly.pattern: "**" only acts as globstar when alone as a path element
paulhammond commentedon Apr 14, 2025
Thanks for working on this so quickly! This looks right to me...
chore(deps): update module mvdan.cc/sh/v3/cmd/shfmt to v3.12.0 (hetzn…