Skip to content

fix(termenv): prevent hang in Emacs shell - #152

Merged
muesli merged 1 commit into
muesli:masterfrom
bard:master
Dec 6, 2023
Merged

muesli merged 1 commit into
muesli:masterfrom
bard:master

Conversation

@bard

@bard bard commented Sep 15, 2023 •

Copy link
Copy Markdown
Contributor

I noticed lefthook was hanging for several seconds when running inside Emacs shell. I tracked it down to termenv via lipgloss.

Edit: this also happens in Magit and any other Emacs subprocess.

This PR fixes the delay by adding a check for TERM=dumb, which is the default in Emacs shell, as it's already done for TERM=tmux and TERM=screen.

Before:

Screencast.from.2023-09-15.19-24-17.webm

After:

Screencast.from.2023-09-15.19-23-34.webm

@mrexox

mrexox commented Sep 22, 2023

Copy link
Copy Markdown

+1 for this fix!

@sanmai-NL

Copy link
Copy Markdown

@muesli Do you have a planning for looking at this PR?

@muesli

muesli commented Nov 30, 2023

Copy link
Copy Markdown
Owner

Yep, will merge this! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

⌂ 换网址