Skip to content

Tag samples with time as close as possible to the time they were taken - #128

Merged
mstange merged 2 commits into
mstange:mainfrom
vvuk:vladv/fix-mac-sample
Mar 27, 2024
Merged

mstange merged 2 commits into
mstange:mainfrom
vvuk:vladv/fix-mac-sample

Conversation

@vvuk

@vvuk vvuk commented Mar 27, 2024

Copy link
Copy Markdown
Collaborator

This is a fix for #127 -- use the monotonic time for a sample as close as possible to the time the sample was taken. This seems sufficient to fix the issue; I'm not sure what the impact of the Timestamp being off is going to be. I think that's safe, because that timestamp is (again, I think) what's used to group/line up the samples across threads/tasks. But the monotonic time is used for lib op resolution.

@mstange
mstange merged commit dc2dc85 into mstange:main Mar 27, 2024
@mstange

mstange commented Mar 27, 2024

Copy link
Copy Markdown
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址