Repository navigation
Click on link with block child silently fails #1007
Description
Given a link with a block-level child (i.e., display: block), clicking on it will silently fail. No JavaScript or navigation is triggered. (Clicking on the child, however, will work.)
System
- Version: 0.19.0
- Platform: macOS 10.12.6
- Firefox: 56.0; 57.0b6; 58.0a1
- Selenium: py/3.6.0
Testcase
test_click_link.py
import inspect
import os.path
from unittest import TestCase, main
from selenium import webdriver
from selenium.webdriver.common.desired_capabilities import DesiredCapabilities
_DIR = os.path.dirname(os.path.abspath(inspect.getfile(inspect.currentframe())))
class TestClickLink(TestCase):
@classmethod
def setUpClass(cls):
capabilities = DesiredCapabilities.FIREFOX.copy()
capabilities["marionette"] = True
capabilities["moz:firefoxOptions"] = {"log": {"level": "trace"}}
cls.browser = webdriver.Firefox(capabilities=capabilities)
def setUp(self):
self.browser.get("file://{}".format(os.path.join(_DIR, "index.html")))
self.result = self.browser.find_element_by_id("result")
def tearDown(self):
self.browser.get("about:blank")
@classmethod
def tearDownClass(cls):
cls.browser.quit()
def test_click_link_without_child(self):
link = self.browser.find_element_by_link_text("No Child")
link.click()
self.assertEqual(self.result.text, "Link was clicked.")
def test_click_link_with_block_child(self):
link = self.browser.find_element_by_link_text("Block Child")
link.click()
self.assertEqual(self.result.text, "Link was clicked.")
def test_click_link_with_inline_child(self):
link = self.browser.find_element_by_link_text("Inline Child")
link.click()
self.assertEqual(self.result.text, "Link was clicked.")
if __name__ == "__main__":
main()index.html
<html>
<head>
<script type="text/javascript">
function handleClick(e) {
e.preventDefault();
document.querySelector("#result").innerText = "Link was clicked.";
}
</script>
</head>
<body>
<div id="result"></div>
<a href="#" onclick="handleClick(event)">No Child</a>
<a href="#" onclick="handleClick(event)"><div>Block Child</div></a>
<a href="#" onclick="handleClick(event)"><span>Inline Child</span></a>
</body>
</html>Stacktrace
$ python test_click_link.py
F..
======================================================================
FAIL: test_click_link_with_block_child (__main__.TestClickLink)
----------------------------------------------------------------------
Traceback (most recent call last):
File "test_click_link.py", line 39, in test_click_link_with_block_child
self.assertEqual(self.result.text, "Link was clicked.")
AssertionError: '' != 'Link was clicked.'
+ Link was clicked.
----------------------------------------------------------------------
Ran 3 tests in 4.758s
FAILED (failures=1)
Trace-level log
Reacted by Andrew Marshall, Mubelotix and Robert Fletcher
Activity
elliterate commentedon Oct 6, 2017
This may be related to #322.
whimboo commentedon Oct 10, 2017
Thank you for the detailed report. I had a look at it, and indeed is a dupe of issue #322. It's also covered by bug 1374283 for Marionette.
elliterate commentedon Jan 9, 2018
@whimboo #322 was just closed because it doesn't have "a concrete description of the problem or a trace log [you] can use to debug it." Can this one be re-opened, then? While this test passes in Firefox 57.0.4 (and geckodriver 0.19.1), it now fails loudly in 58.0b14 and 59.0a1 with the following:
Trace-level log
geckodriver.log.2.txt
andreastt commentedon Jan 9, 2018
Sounds like a fallout from the changes to make Element Click conform to the WebDriver standard, but this needs more investigation.
whimboo commentedon Jan 10, 2018
The failure here happens for the following
<a>node:So the
<div>is completely overlaying the link here. This should be https://bugzilla.mozilla.org/show_bug.cgi?id=1374283.