Skip to content

Remote Explorer: when there is only one view, split view should not be present #86037

Closed

Description

Refs: #85908

  1. Have a contributed view container like remote
  2. Hide all views except one
  3. That view is still shown in a split view. Instead it should be merged with the container (same as our vscode container behave, for example Explorer). It should no longer be inside a split view

This is also happening in Insiders
fyi Sandeep Somavarapu (@sandy081)

Activity

  1. sandy081 commented on Dec 3, 2019

    @sandy081
    Member

    I think this is expected ad remote viewlet has special behaviour and is not merged.

    Alex Ross (@alexr00) Please confirm?

  2. alexr00 commented on Dec 3, 2019

    @alexr00
    Member

    That is correct, remote viewlet has special behavior and is not merged since the merging conflicts with the drop down.

  3. isidorn commented on Dec 3, 2019

    @isidorn
    Author

    I find that inconsistent - couldn't we merge the actions from the container with the actions of the view? Would there be too much?
    Feel free to close as designed.

  4. alexr00 commented on Dec 3, 2019

    @alexr00
    Member

    Since the drop-down functions as a filter I think keeping the things it filters (views, including actions) below it it is clearer than having the title change and having actions move to be next to the drop-down. If we merge, it could look like those are top level actions and a top level title, which it is not. I will bring up at the next UX sync to get more input.

  5. added
    remoteRemote system operations issues
    under-discussionIssue is under discussion for relevance, priority, approach
    on Dec 3, 2019
  6. isidorn commented on Dec 3, 2019

    @isidorn
    Author

    That's makes sense, however since it is for a UX sync, we will probably not tackle it this week. Thus maybe assign to next milestone not this one?

  7. alexr00 commented on Jan 8, 2020

    @alexr00
    Member

    After UX discussion, this is the goal:
    image
    Then when there is only one view, the title still makes sense and there is room for the buttons.

  8. 7 remaining items

  9. added
    bugIssue identified by VS Code Team member as probable bug
    on Nov 9, 2020
  10. added
    feature-requestRequest for new features or functionality
    and removed
    bugIssue identified by VS Code Team member as probable bug
    on Nov 10, 2021
  11. locked and limited conversation to collaborators on Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

*as-designedDescribed behavior is as designedfeature-requestRequest for new features or functionalitypolishCleanup and polish issueremote-explorerRemote explorer view

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    ⌂ 换网址