You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need to introduce a contributable menu to the Debug: Start view such that each extension can contribute commands tehre.
We would have to enforce when context on top of these contributed commands just so the view does not end up being a jungle. For example when activeFile is python add the python commands.
An open question is how these contributed commands would look like, would it also be a blue button, or is there a ... affordance which when clicked shows all the contributed commands.
John Murray (@gjsjohnmurray) correct. We decided to change that behavior, that focus is first passed to the view, and then the user can navigate to focus what button / text he wants. We think this makes the most sense from the accessibility standpoint.
Connor Peet (@connor4312)roblourens please note that the debug start view is now contributable to.
You could potentially add an action to open the Javascript Debugger.
I am still thinking about context keys and will keep you updated on that.
Here's an example how Git extension contributes a button to the explorer view
I will also store the value of the context key per workspace storage.
So when a user starts vscode again and has no editor open that we preserve the last language he was interetsed in. Thus the contributed buttons would still be there.
Debug welcome view is now supporting contributing welcome content via static package.json API.
Thus extensions can contribute text and buttons to the welcome view. The idea is to introduce actions and help text that should make it easier for users to start debugging.
Please note that we would like to keep this view not cluttered, thus we highly recommend that you use the context key debugStartLanguage. More about this context key can be found in my comment here.
API details here #89080
This is still proposed API and we are in the transition of making the API final - which should happen in the March milestone. Example how to js-debug did this microsoft/vscode-js-debug@9e6dc67
Activity
isidorn commentedon Dec 24, 2019
For now I believe a better approach is for each extension to contribute a view, for example microsoft/vscode-python-debugger#164
Due to that pushing this feature request out of this milestone and we can reconsider this in the future if needed.
isidorn commentedon Feb 19, 2020
Debug start view can now be contributed to. We still need to:
fyi João Moreno (@joaomoreno)
Make initial debug / run view extensible
gjsjohnmurray commentedon Feb 20, 2020
This seems to have landed in today's Insiders. I noticed that we're getting a focus rectangle that doesn't occur on Stable:
isidorn commentedon Feb 20, 2020
John Murray (@gjsjohnmurray) correct. We decided to change that behavior, that focus is first passed to the view, and then the user can navigate to focus what button / text he wants. We think this makes the most sense from the accessibility standpoint.
isidorn commentedon Feb 20, 2020
Connor Peet (@connor4312) roblourens please note that the debug start view is now contributable to.
You could potentially add an action to open the Javascript Debugger.
I am still thinking about context keys and will keep you updated on that.
Here's an example how Git extension contributes a button to the explorer view
vscode/extensions/git/package.json
Line 1858 in 093ada3
The id of the debug start view is
workbench.debug.startViewfyi Andre Weinand (@weinand)
weinand commentedon Feb 20, 2020
I think the contributed action should open the debug terminal.
3 remaining items
isidorn commentedon Feb 21, 2020
I will also store the value of the context key per workspace storage.
So when a user starts vscode again and has no editor open that we preserve the last language he was interetsed in. Thus the contributed buttons would still be there.
debug start language: store the value of the context key per workspac…
joaomoreno commentedon Feb 21, 2020
Isidor Nikolic (@isidorn) Telemetry is in: a1f61fd
isidorn commentedon Feb 21, 2020
Thanks a lot! Very elegant :)
joaomoreno commentedon Feb 21, 2020
Isidor Nikolic (@isidorn) And here are preconditions for button enablement (internal only): 0c1c8f2
isidorn commentedon Feb 21, 2020
Awesome, adopted it for debug. 🎉
connor4312 commentedon Feb 21, 2020
I probably won't have time to do this before endgame, but would be happy to accept a PR or take care of it next iteration.
[-]Make initial debug / run view extensible[/-][+]Make run and debug welcome view extensible[/+]isidorn commentedon Mar 6, 2020
Dear debug protocol implementers,
Debug welcome view is now supporting contributing welcome content via static
package.jsonAPI.Thus extensions can contribute text and buttons to the welcome view. The idea is to introduce actions and help text that should make it easier for users to start debugging.
Please note that we would like to keep this view not cluttered, thus we highly recommend that you use the context key
debugStartLanguage. More about this context key can be found in my comment here.API details here #89080
This is still proposed API and we are in the transition of making the API final - which should happen in the March milestone.
Example how to js-debug did this microsoft/vscode-js-debug@9e6dc67
Antonino Perricone (@APerricone), Rome Li (@akaroml), Andy Sterland (@andysterland), Igor Kulaychuk (@ayuckhulk), Danny Tuppeny (@DanTup), David Wilson (@daviwil), Devon Carew (@devoncarew), Dibyendu Majumdar (@dibyendumajumdar), Don Jayamanne (@DonJayamanne), Felix Becker (@felixfbecker), Glenn Sarti (@glennsarti), Gregg Miskelly (@gregg-miskelly), Holger Benl (@hbenl), Ivan (@iradul), Ivan Buhov (@ivanbuhov), Joel Day (@joelday), James Pogran (@jpogran), Josh Tynjala (@joshtynjala), Kode (@Kode), Nicklas Pingel (@miniwolf), Jimmy Thomson (@MSLaguana), Luciana Abud (@luabud), lukaszunity, Nate Totten (@ntotten), phoityne, Pierson Lee (@pieandcakes), Peter Thomas (@ptrthomas), Morten N.O. Nørgaard Henriksen (@raix), Gerald Richter (@richterger), Keith Hill (@rkeithhill), Peng Lyu (@rebornix), roblourens, Sami Vaarala (@svaarala), Jinbo Wang (@testforstephen), vadimcn, vshaxe (@vshaxe), Jan Jurzitza (@WebFreak001), Andre Weinand (@weinand), Yury Delendik (@yurydelendik)
pieandcakes commentedon Mar 6, 2020
Andrew Wang (@WardenGnaw)
raix commentedon Mar 8, 2020
Do we have to support translations in the wellcome text?
isidorn commentedon Mar 9, 2020
Morten N.O. Nørgaard Henriksen (@raix) that would be great, since the welcome text is user facing and all user facing text should be translated.