Skip to content

Make run and debug welcome view extensible #85548

Closed

Description

We need to introduce a contributable menu to the Debug: Start view such that each extension can contribute commands tehre.

We would have to enforce when context on top of these contributed commands just so the view does not end up being a jungle. For example when activeFile is python add the python commands.

An open question is how these contributed commands would look like, would it also be a blue button, or is there a ... affordance which when clicked shows all the contributed commands.

Activity

  1. added
    feature-requestRequest for new features or functionality
    debugDebug viewlet, configurations, breakpoints, adapter issues
    on Nov 25, 2019
  2. isidorn commented on Dec 24, 2019

    @isidorn
    Author

    For now I believe a better approach is for each extension to contribute a view, for example microsoft/vscode-python-debugger#164

    Due to that pushing this feature request out of this milestone and we can reconsider this in the future if needed.

  3. isidorn commented on Feb 19, 2020

    @isidorn
    Author

    Debug start view can now be contributed to. We still need to:

    • show button as disabled
    • add telemetry
    • render keybindings
    • figure out a context for extensions to use
    • make sure my buttons are at the top

    fyi João Moreno (@joaomoreno)

  4. gjsjohnmurray commented on Feb 20, 2020

    @gjsjohnmurray
    Contributor

    This seems to have landed in today's Insiders. I noticed that we're getting a focus rectangle that doesn't occur on Stable:

    image

  5. isidorn commented on Feb 20, 2020

    @isidorn
    Author

    John Murray (@gjsjohnmurray) correct. We decided to change that behavior, that focus is first passed to the view, and then the user can navigate to focus what button / text he wants. We think this makes the most sense from the accessibility standpoint.

  6. isidorn commented on Feb 20, 2020

    @isidorn
    Author

    Connor Peet (@connor4312) roblourens please note that the debug start view is now contributable to.
    You could potentially add an action to open the Javascript Debugger.
    I am still thinking about context keys and will keep you updated on that.
    Here's an example how Git extension contributes a button to the explorer view

    "view": "workbench.explorer.emptyView",

    The id of the debug start view is workbench.debug.startView

    fyi Andre Weinand (@weinand)

  7. weinand commented on Feb 20, 2020

    @weinand
    Contributor

    I think the contributed action should open the debug terminal.

  8. 3 remaining items

  9. isidorn commented on Feb 21, 2020

    @isidorn
    Author

    I will also store the value of the context key per workspace storage.
    So when a user starts vscode again and has no editor open that we preserve the last language he was interetsed in. Thus the contributed buttons would still be there.

  10. joaomoreno commented on Feb 21, 2020

    @joaomoreno
    Contributor
  11. isidorn commented on Feb 21, 2020

    @isidorn
    Author

    Thanks a lot! Very elegant :)

  12. joaomoreno commented on Feb 21, 2020

    @joaomoreno
    Contributor

    Isidor Nikolic (@isidorn) And here are preconditions for button enablement (internal only): 0c1c8f2

  13. isidorn commented on Feb 21, 2020

    @isidorn
    Author

    Awesome, adopted it for debug. 🎉

  14. connor4312 commented on Feb 21, 2020

    @connor4312
    Member

    I probably won't have time to do this before endgame, but would be happy to accept a PR or take care of it next iteration.

  15. changed the title [-]Make initial debug / run view extensible[/-] [+]Make run and debug welcome view extensible[/+] on Mar 6, 2020
  16. isidorn commented on Mar 6, 2020

    @isidorn
    Author

    Dear debug protocol implementers,

    Debug welcome view is now supporting contributing welcome content via static package.json API.
    Thus extensions can contribute text and buttons to the welcome view. The idea is to introduce actions and help text that should make it easier for users to start debugging.
    Please note that we would like to keep this view not cluttered, thus we highly recommend that you use the context key debugStartLanguage. More about this context key can be found in my comment here.

    API details here #89080
    This is still proposed API and we are in the transition of making the API final - which should happen in the March milestone.
    Example how to js-debug did this microsoft/vscode-js-debug@9e6dc67

    image

    Antonino Perricone (@APerricone), Rome Li (@akaroml), Andy Sterland (@andysterland), Igor Kulaychuk (@ayuckhulk), Danny Tuppeny (@DanTup), David Wilson (@daviwil), Devon Carew (@devoncarew), Dibyendu Majumdar (@dibyendumajumdar), Don Jayamanne (@DonJayamanne), Felix Becker (@felixfbecker), Glenn Sarti (@glennsarti), Gregg Miskelly (@gregg-miskelly), Holger Benl (@hbenl), Ivan (@iradul), Ivan Buhov (@ivanbuhov), Joel Day (@joelday), James Pogran (@jpogran), Josh Tynjala (@joshtynjala), Kode (@Kode), Nicklas Pingel (@miniwolf), Jimmy Thomson (@MSLaguana), Luciana Abud (@luabud), lukaszunity, Nate Totten (@ntotten), phoityne, Pierson Lee (@pieandcakes), Peter Thomas (@ptrthomas), Morten N.O. Nørgaard Henriksen (@raix), Gerald Richter (@richterger), Keith Hill (@rkeithhill), Peng Lyu (@rebornix), roblourens, Sami Vaarala (@svaarala), Jinbo Wang (@testforstephen), vadimcn, vshaxe (@vshaxe), Jan Jurzitza (@WebFreak001), Andre Weinand (@weinand), Yury Delendik (@yurydelendik)

  17. pieandcakes commented on Mar 6, 2020

    @pieandcakes
    Contributor
  18. raix commented on Mar 8, 2020

    @raix

    Do we have to support translations in the wellcome text?

  19. isidorn commented on Mar 9, 2020

    @isidorn
    Author

    Morten N.O. Nørgaard Henriksen (@raix) that would be great, since the welcome text is user facing and all user facing text should be translated.

  20. locked and limited conversation to collaborators on Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

debugDebug viewlet, configurations, breakpoints, adapter issuesfeature-requestRequest for new features or functionalityon-release-notesIssue/pull request mentioned in release noteson-testplan

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    ⌂ 换网址