Skip to content

New terminal lines rendering cuts off bottom/top of characters like underscore #35901

Closed

Description

The new terminal rendering cuts off the bottom part of "long" characters, such as g, j and y.

1.17.0:
image

1.17.1:
image

  • VSCode Version: 1.17.0
Version 1.17.0
Commit be377c0faf7574a59f84940f593a6849f12e4de7
Date 2017-10-04T23:33:45.303Z
Shell 1.7.7
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64
  • OS Version: Ubuntu Trusty 14.04

Steps to Reproduce:

  1. Open the Terminal
  2. Start typing git checkout -b feature/object

Reproduces without extensions: Yes

Activity

  1. added
    terminalGeneral terminal issues that don't fall under another label
    on Oct 9, 2017
  2. fpauser commented on Oct 9, 2017

    @fpauser

    Same problem here.

  3. masonj5n commented on Oct 9, 2017

    @masonj5n

    Chops the top off on Fedora 26.
    badterminal

  4. imgss commented on Oct 10, 2017

    @imgss

    Same problem here.

  5. ivcosla commented on Oct 10, 2017

    @ivcosla

    I just changed the "terminal.integrated.fontFamily" value. My issue was that underscores were not displayed using DejaVu Sans Mono. With other fonts they are displaying, not sure if it would help to fix your problem guys, but sure is worth to give it a try.

  6. jashworth commented on Oct 10, 2017

    @jashworth

    The variable width font that I'm partial to now renders like this.

    image

  7. Tyriar commented on Oct 10, 2017

    @Tyriar
    Contributor
  8. added
    bugIssue identified by VS Code Team member as probable bug
    on Oct 10, 2017
  9. Tyriar commented on Oct 10, 2017

    @Tyriar
    Contributor

    Viktor Kunovski (@viktorku) what's in your settings.json file?

  10. viktorku commented on Oct 11, 2017

    @viktorku
    Author

    In 1.17.1 the rendering changed (it's somewhat blurrier and smaller fontsize - see top comment for comparison) but the bug prevails:

    image

    Daniel Imms (@Tyriar) This also happens for a fresh code instance (without settings.json in the project's root .vscode). My User Settings are like this:

    {
        "workbench.sideBar.location": "left",
        "files.exclude": {
            "**/.git*": false,
            "**/.svn": true,
            "**/.hg": true,
            "**/.DS_Store": true,
            "**/.tags*": true,
    	"**/.pyc": true,
            ".catkin_tools/**/packages": true,
            "build": true,
            "devel": true,
            "logs": true,
            "src/external": true,
            "**/CMakeLists.txt.user": true,
            "**/__pycache__": true
        },
    
        "editor.fontSize": 12,
        "editor.tabSize": 2,
        "editor.wordWrap": "on",
        "editor.rulers": [
            100
        ],
    
        "[python]": {
            "editor.tabSize": 4
        },
    
        "files.trimTrailingWhitespace": true,
        "diffEditor.ignoreTrimWhitespace": false,
    
        "workbench.editor.enablePreviewFromQuickOpen": false,
    
        "window.zoomLevel": 0,
    
        "clang-format.executable": "/usr/bin/clang-format-3.8",
        "clang-format.style": "Google",
        "clang-format.language.javascript.enable": false,
    
        "prettier.printWidth": 100,
        "prettier.singleQuote": true,
        "prettier.bracketSpacing": true,
        "workbench.colorTheme": "One Dark Pro",
    
        "editor.multiCursorModifier": "alt",
        "git.ignoreLegacyWarning": true,
        "workbench.startupEditor": "newUntitledFile",
    
        "eslint.nodePath": "/home/viktor/.nvm/versions/node/v7.4.0/bin/node",
    
        "python.linting.pylintArgs": [
            "--load-plugins pylint-django"
        ]
    }
  11. changed the title [-]New terminal rendering lines cut off bottom of long characters[/-] [+]New terminal lines rendering cuts off bottom of long characters[/+] on Oct 11, 2017
  12. 95 remaining items

  13. l-miskovsky commented on Nov 8, 2019

    @l-miskovsky

    Underscores are finally visible with fontSize: 14 and the latest 1.40 version 🎉

  14. vinicpac commented on Nov 10, 2019

    @vinicpac

    surges (@surges)
    Underscores are finally visible with fontSize: 14 and the latest 1.40 version

    Still not working for me on: Ubuntu 18.04.3 LTS x64, VS Code 1.40

    I have to use the workaround "terminal.integrated.fontSize": 15" in order to see the underscore.

  15. Bessonov commented on Nov 10, 2019

    @Bessonov

    @viniciussp4 I use my docker image with ubuntu 18.04 for development and I see the underscores:
    https://github.com/Bessonov/dev-image

    Can you check your installation and vscode settings or the image?
    https://github.com/Bessonov/dev-image/blob/master/Dockerfile#L28

    I mean, if it's working in a reproducible way with docker, then it could be a local problem.

    image

  16. nobi1007 commented on Nov 13, 2019

    @nobi1007

    Daniel Imms (@Tyriar)

    The line height workaround doesn't work for me in latest insiders

    Running Ubuntu in virtualbox

    • VSCode Version: Code - Insiders 1.18.0-insider (81cca6c, 2017-10-31T06:24:27.011Z)
    • OS Version: Linux x64 4.10.0-37-generic

    In my screenshot I typed some underscores _________
    image

    I also tried crazy heights like 2 but nothing seems to help

    This is a regression from 1.17 where it displays fine:
    image

    Setting terminal.integrated.fontSize": 13 is a workaround for me

    I don't get it but only the with font-size of 14 there comes the problem, but with other font sizes it not the case. Any reason ??

  17. segevfiner commented on Nov 13, 2019

    @segevfiner
    Contributor

    It's an off by one error in measuring the "height" of the font that doesn't happen in all font sizes in the canvas renderer of xterm.js. If there is someway to fix up this computation then that would fix this for the canvas renderer. I think there was an issue in xterm.js where I explained my investigation of this.

  18. Tyriar commented on Nov 14, 2019

    @Tyriar
    Contributor

    The issue is that rows are clipped so that we can render rows independently, otherwise the whole terminal would need an update. #84440 fixes this and makes the terminal way faster so stay tuned 😃

  19. hems commented on Dec 5, 2019

    @hems

    I'm running OSX and I used to have "ProggyCleanTTSZ" ( from the amazing https://proggyfonts.net/ ) and it worked like a charm.

    One day i decided to accept the "Update" on VS Code and that terrible update started cropping my text on the terminal.

    I played with all settings possible here in this thread and nothing worked other than changing my font to "monospace", which is less than ideal as i'm used to use ProggyClean for over 15 years now 😢

    I hope this get fixed before i move back to vim, which perhaps i should never have left, lol

  20. Tyriar commented on Dec 5, 2019

    @Tyriar
    Contributor

    hems.io (@hems) that's a bug in Chromium that shows up on some fonts #84432, https://bugs.chromium.org/p/chromium/issues/detail?id=1026254

  21. hems commented on Dec 6, 2019

    @hems

    hems.io (@hems) that's a bug in Chromium that shows up on some fonts #84432, https://bugs.chromium.org/p/chromium/issues/detail?id=1026254

    hopefully fixed soon

  22. Tyriar commented on Dec 6, 2019

    @Tyriar
    Contributor

    You can try out the new WebGL-based renderer where this issue is fixed by using this:

    "terminal.integrated.rendererType": "experimentalWebgl"
    

    It's available in Insiders and in the upcoming version.

    The canvas renderer will eventually be removed as the webgl one is basically a highly optimized/low-level version of it.

  23. hems commented on Dec 16, 2019

    @hems

    "terminal.integrated.rendererType": "experimentalWebgl"

    that just gave me new problems, like my text is rendered out of the Terminal box sometimes and i can't see it. but if i type for instance ls -la then i can se the result because it spans many lines.

  24. Tyriar commented on Dec 27, 2019

    @Tyriar
    Contributor

    hems.io (@hems) I haven't heard of a problem like that before, please report in a new issues with repro steps.

  25. locked and limited conversation to collaborators on Dec 31, 2019
  26. Tyriar commented on Nov 4, 2020

    @Tyriar
    Contributor

    If you're still on the canvas renderer, hems.io (@hems) calls out a workaround in #107942 (comment) to regenerate the font file:

    After months and months having the issue with my font being cropped on the bottom of the terminal i managed to solve the issue by importing the font into https://www.glyphrstudio.com/online/ then export it as OTF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugIssue identified by VS Code Team member as probable bugterminalGeneral terminal issues that don't fall under another labelupstreamIssue identified as 'upstream' component related (exists outside of VS Code)upstream-issue-linkedThis is an upstream issue that has been reported upstream

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    ⌂ 换网址