Skip to content

Add proxy support to http2 requests in the extension host #185098

Open

Description

Previously reverted: #189133

Activity

  1. 13 remaining items

  2. chrmarti commented on Sep 25, 2023

    @chrmarti
    CollaboratorAuthor

    Opened nodejs/node#49860 for Node.

  3. kryops commented on Oct 2, 2023

    @kryops

    The system certificate loading V2 also seems to affect the native fetch API.

    We conditionally include a polyfill to node-fetch:

    import fetch, { Headers, Request, Response } from 'node-fetch';
    
    if (!global.fetch) {
      global.fetch = fetch;
      global.Response = Response;
      global.Headers = Headers;
      global.Request = Request;
    }

    This stopped working in VS Code 1.82 due to the Node 18 update that made fetch globally available, but apparently without support for system certificates.

    When we checked the insiders build, it was working again, but since #194408 it only works with the "Http › Experimental: System Certificates V2" configuration activated.

    Does this belong here or should I open a separate issue to track system certificate support for fetch?

  4. chrmarti commented on Oct 2, 2023

    @chrmarti
    CollaboratorAuthor

    Michael Manzinger (@kryops) This is the right place, thanks.

  5. added
    feature-requestRequest for new features or functionality
    and removed
    plan-itemVS Code - planned item for upcoming
    on Oct 26, 2023
  6. kryops commented on Dec 12, 2024

    @kryops

    The system certificate support for fetch seems to have been fixed by #233104 🚀

  7. tmm1 commented on Apr 29, 2025

    @tmm1
    Contributor

    Curious what the current state and plans for http2 proxy support are.

    A lot of the discussion and blockers above are related to cert handling, which proxy-agent is also responsible for (although hopefully for not much longer: #247003 (comment)).

    It's not clear whether any work was done on the proxy server handling side?

  8. chrmarti commented on May 5, 2025

    @chrmarti
    CollaboratorAuthor

    It turned out to be easier to add proxy support to fetch which supports http2 (though not enabled by default yet, see nodejs/undici#2750 (comment)). There is no work planned for adding support to the http2 module at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

feature-requestRequest for new features or functionalityproxyIssues regarding network proxies

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    ⌂ 换网址