Skip to content

Restore view state for cells from redundant fs file change event #157695

Closed

Description

@rebornix

Originally posted by in #153708 (comment)

As in the demo/gif in #153708, when we receive a content change event which contains no real model change, we still reset the model and lost all view states, which will trigger a flicker when the editor has horizontal scrollbars.

We should avoid the handling of such "redundant" file change events.

Activity

  1. rebornix commented on Aug 19, 2022

    @rebornix
    ContributorAuthor

    Verification:

    • Open a notebook file in VS Code
    • Select some text in a cell editor
    • Open terminal, touch file.ipynb to trigger a file change event
    • Make sure the cell editor selection doesn't change
  2. locked and limited conversation to collaborators on Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    ⌂ 换网址