Repository navigation
Fix combined packaging stage - #33561
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped change uses the correct task ordering and matches the existing packaging environment.
No open issues 🎉
What changed in this PR
This PR makes the Python interpreter explicit for ONNX Runtime’s package validation step in Azure Pipelines.
Changes:
- Adds
UsePythonVersion@0before package validation to select Python 3.12. - Adds the selected interpreter to
PATHfor the followingPythonScript@0task.
No actionable issues were identified.
| File | Description |
|---|---|
| tools/ci_build/github/azure-pipelines/templates/validate-package.yml | Sets up Python 3.12 before running package validation. |
Review effort: Balanced
Edward Chen (edgchen1)
approved these changes
Oct 23, 2026
Tianlei Wu (tianleiwu)
approved these changes
Oct 23, 2026
adrastogi
added a commit
that referenced
this pull request
Oct 27, 2026
### Description <!-- Describe your changes. --> This cherry-picks the following commit for the release: * #33561 (`7ec270791d92a789db39c868e565d05ce7d1654b`): set up Python 3.12 before running package validation in the combined packaging stage. The cherry-pick applied cleanly, with source commit provenance preserved. This branch is based on the current `rel-1.30.1`, including the servicing payload merged in #33524. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Bring the packaging-stage fix into ORT 1.30.1 so package validation has an explicitly selected Python interpreter before the next internal release build. Validation: * The cherry-pick patch ID matches the original mainline commit. * YAML parsing and assertions passed: Python 3.12 setup precedes the existing package-validation task. * `git diff --cached --check` passed before committing. * The internal release pipelines have not been rerun with this change. Co-authored-by: eserscor <erscor@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3eb3fc9b-6147-4706-b7ad-47bb3476377b
adrastogi
added a commit
that referenced
this pull request
Oct 27, 2026
### Description <!-- Describe your changes. --> This cherry-picks the following commit for the release: * #33142 (`38dc99fba3f5bd72e201d1d942235bf4f600a1b3`): work around the Windows certificate regression in build-tools setup by installing and injecting `truststore`, inspecting proxy settings, and sanitizing `NO_PROXY` before invoking the GitHub Action wrapper. The full two-file cherry-pick applied cleanly, with source commit provenance preserved. This branch is based on current `rel-1.30.1`, including #33524 and #33641. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> The internal release build failed in six Windows packaging jobs while downloading the build-tools action through `run_gh_action.py`: `CERTIFICATE_VERIFY_FAILED: unable to get local issuer certificate` This upstream fix enables Python to use system-trusted certificates without disabling certificate verification. The previous Python-version fix (#33561, backported through #33641) is present and package validation passed in both release runs. This PR does not address the separate macOS checkout timeout or the Maven feed connection timeout in the CUDA13 build. Those failures need targeted infrastructure retries; no additional cherry-picks are currently indicated. Validation: * The cherry-pick patch ID matches the original mainline commit. * Python AST parsing and YAML parsing/assertions passed: `truststore` installation/injection and the PowerShell wrapper invocation are present. * `git diff --cached --check` passed before committing. * No end-to-end execution on the affected release agents was performed. No release pipelines were restarted. Co-authored-by: eserscor <erscor@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3eb3fc9b-6147-4706-b7ad-47bb3476377b
This was referenced Oct 30, 2026
This was referenced Nov 2, 2026
Open
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Azure Pipelines configuration to explicitly set the Python version used during the package validation step. The main change is the addition of a task to ensure Python 3.12 is available in the build environment before running validation scripts.
Pipeline environment update:
UsePythonVersion@0task invalidate-package.ymlto set up Python 3.12 before running the package validation script, ensuring consistent Python environment across builds.