Repository navigation
Add external Dawn API package CI coverage for the WebGPU plugin - #33077
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No actionable issues were found in the plugin integration, negative-test handling, or CI ordering.
Review effort: Balanced
Findings: None
What changed in this PR
Adds Windows CI coverage for external Dawn API packages with the WebGPU plugin, addressing #33043 while retaining built-in coverage.
Changes:
- Registers and explicitly selects the plugin, forwarding the host’s
dawnProcTable. - Builds package-backed core and plugin DLLs and runs inference and rejection tests.
- Prevents unrelated plugin-load failures from passing the missing-proc-table test.
| File | Description |
|---|---|
onnxruntime/test/webgpu/external_dawn/main.cc |
Adds plugin selection and stricter negative-test handling. |
.github/workflows/windows_webgpu.yml |
Adds package-backed plugin builds and runtime tests. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Mustapha Jaber (mustjab)
marked this pull request as ready for review
October 3, 2026 01:17
Mustapha Jaber (mustjab)
enabled auto-merge (squash)
October 3, 2026 05:47
Jiajia Qin (qjia7)
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
External Dawn API package CI currently exercises the built-in WebGPU EP, but not the shared-plugin registration and provider-option path.
dawnProcTablethroughAppendExecutionProvider_V2.Fixes #33043.
Validation
Windows x64 Release:
Other native platforms have not been validated locally.