Repository navigation
Fix WebGPU subgroup config header dependency - #32672
Merged
Ti-Tai Wang (titaiwangms) merged 1 commit intoSep 17, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The dependency split is correct, localized, and preserves runtime behavior.
Pull request overview
Fixes WebGPU plugin compilation by removing an unnecessary transitive dependency from the subgroup configuration header.
Changes:
- Includes only Dawn WebGPU types and forward-declares
ComputeContextBase. - Moves the full compute-context dependency into the implementation file.
File summaries
| File | Description |
|---|---|
subgroup_matrix_config.h |
Reduces public header dependencies. |
subgroup_matrix_config.cc |
Includes the complete compute-context definition. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ti-Tai Wang (titaiwangms)
approved these changes
Sep 17, 2026
Ti-Tai Wang (titaiwangms)
deleted the
fix/webgpu-subgroup-config-header
branch
September 17, 2026 22:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
compute_context.hdependency insubgroup_matrix_config.hwith the Dawn type header and a forward declaration ofComputeContextBase.compute_context.hin the implementation file where the complete type is required.Motivation and Context
#32667 added
subgroup_matrix_config.htomatmul_test.cc. In WebGPU plugin builds, the old transitive include chain reachedwebgpu_execution_provider.hwithout the EP adapter precompiled header, soonnxruntime::ep::adapter::Loggerwas undeclared. This brokewebgpu_plugin_build_x64_RelWithDebInfoboth on #32667 and onmain.Keeping the implementation dependency out of the public configuration header fixes the plugin test build and avoids exposing the execution-provider header to callers that only need subgroup matrix configuration types.
Failing main run: https://github.com/microsoft/onnxruntime/actions/runs/35204008069
Testing
git diff --check