Skip to content

Deprecate ACL EP - #32564

Merged
Edward Chen (edgchen1) merged 3 commits into
mainfrom
edgchen1/deprecate_acl_ep
Sep 14, 2026
Merged

Edward Chen (edgchen1) merged 3 commits into
mainfrom
edgchen1/deprecate_acl_ep

Conversation

@edgchen1

Copy link
Copy Markdown
Contributor

Description

Add deprecation warning for --use_acl build option. Add readme and comments about deprecation.

Motivation and Context

Deprecating the ACL EP.

Add deprecation warning for --use_acl build option. Add readme and comments about deprecation.
Copilot AI balanced review requested due to automatic review settings September 11, 2026 18:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new ACL warning behavior lacks coverage in the existing build-argument unit tests.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Deprecates the ACL Execution Provider and warns users during build argument parsing.

Changes:

  • Marks ACL build options as deprecated and emits a visible warning.
  • Adds an ACL deprecation notice.
  • Makes the existing CUDA NHWC deprecation warning visible.
File summaries
File Description
tools/ci_build/build_args.py Adds CLI deprecation messaging and warnings.
onnxruntime/core/providers/acl/readme.md Documents ACL EP deprecation.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tools/ci_build/build_args.py Resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The deprecation is consistently communicated and its warning behavior is adequately tested.

Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@edgchen1
Edward Chen (edgchen1) merged commit 719b9fa into main Sep 14, 2026
91 checks passed
@edgchen1
Edward Chen (edgchen1) deleted the edgchen1/deprecate_acl_ep branch September 14, 2026 22:40
This was referenced Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址