Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Option to use number for user and/or group names - #385

Merged
mholt merged 3 commits into
mholt:masterfrom
breezerider:tar-numeric-uid-gid
Sep 14, 2023
Merged

mholt merged 3 commits into
mholt:masterfrom
breezerider:tar-numeric-uid-gid

Conversation

@breezerider

Copy link
Copy Markdown
Contributor
  • add NumericUid and NumericGid to Tar struct
  • writeFileToArchive: set Uname and Gname to empty string if NumericUid and NumericGid are true, respectively.

* add NumericUid and NumericGid to Tar struct
* writeFileToArchive: set Uname and Gname to empty string if NumericUid and NumericGid are true, respectively.
@mholt

mholt commented Sep 5, 2023

Copy link
Copy Markdown
Owner

Thanks! Is there a reason one would be true but not the other?

@breezerider

Copy link
Copy Markdown
Contributor Author

No real use case on my side, just left it like that for flexibility. Primary use case is to prevent aliasing and this means both flags are set simultaneously. Do you think it makes sense to join them?

@mholt

mholt commented Sep 11, 2023

Copy link
Copy Markdown
Owner

I think we should probably join them unless there's a valid use case for having them separated. We're still in alpha so we could change this later if there's a valid use case brought forth.

* join NumericUid and NumericGid in Tar struct
* name the new option NumericUidGid

@mholt mholt left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is good. I'm just changing UidGid to UIDGID, as dumb as that looks, because the convention I'm used to capitalizes initialisms 🙃

I appreciate the change!!

Comment thread tar.go Resolved
Comment thread tar.go Resolved
@mholt
mholt merged commit 1de2118 into mholt:master Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址