This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Repository navigation
Option to use number for user and/or group names - #385
Merged
Merged
Conversation
breezerider
commented
Sep 3, 2023
Contributor
- add NumericUid and NumericGid to Tar struct
- writeFileToArchive: set Uname and Gname to empty string if NumericUid and NumericGid are true, respectively.
* add NumericUid and NumericGid to Tar struct * writeFileToArchive: set Uname and Gname to empty string if NumericUid and NumericGid are true, respectively.
Owner
|
Thanks! Is there a reason one would be true but not the other? |
Contributor
Author
|
No real use case on my side, just left it like that for flexibility. Primary use case is to prevent aliasing and this means both flags are set simultaneously. Do you think it makes sense to join them? |
Owner
|
I think we should probably join them unless there's a valid use case for having them separated. We're still in alpha so we could change this later if there's a valid use case brought forth. |
* join NumericUid and NumericGid in Tar struct * name the new option NumericUidGid
mholt
approved these changes
Sep 14, 2023
mholt
left a comment
Owner
There was a problem hiding this comment.
Thanks! This is good. I'm just changing UidGid to UIDGID, as dumb as that looks, because the convention I'm used to capitalizes initialisms 🙃
I appreciate the change!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.