Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Bugfix: Tar files created in their target directory shouldn't recurse infinitely - #384

Merged
mholt merged 5 commits into
mholt:masterfrom
drewstinnett:bugfix-embedded-tars
Aug 31, 2023
Merged

mholt merged 5 commits into
mholt:masterfrom
drewstinnett:bugfix-embedded-tars

Conversation

@drewstinnett

Copy link
Copy Markdown
Contributor

This addresses #383 .

Happy to refactor however you like, and open to any feedback. Thank you!

@mholt mholt left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! I have not encountered this situation so I appreciate the test case. Is the right behavior really to just skip the file?

Comment thread fs.go Resolved
Updating per suggestion, looks great!

Co-authored-by: Matt Holt <mholt@users.noreply.github.com>
@drewstinnett

Copy link
Copy Markdown
Contributor Author

Thanks for the patch! I have not encountered this situation so I appreciate the test case. Is the right behavior really to just skip the file?

Yep! At least to the best of my knowledge skipping this sub '.' entry keeps everything going, correctly. I tested it on some random archives here and they all behaved correctly with that weird entry being completely skipped.

@mholt mholt left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after I fix my syntax error

Comment thread fs.go Resolved
@mholt
mholt merged commit e2261a1 into mholt:master Aug 31, 2023
@mholt mholt added the bug label Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址