Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

ignore empty root dir name when compressing file - #355

Merged
mholt merged 2 commits into
mholt:masterfrom
WeidiDeng:patch-2
Oct 19, 2022
Merged

mholt merged 2 commits into
mholt:masterfrom
WeidiDeng:patch-2

Conversation

@WeidiDeng

Copy link
Copy Markdown
Contributor

fix 350

@WeidiDeng WeidiDeng mentioned this pull request Oct 17, 2022
@mholt

mholt commented Oct 17, 2022

Copy link
Copy Markdown
Owner

Thanks! I'll await confirmation from @nicola-spb and if it fixes the issue we can merge this in

@WeidiDeng

Copy link
Copy Markdown
Contributor Author

I find that FilesFromDisk will never return error, because it never checks error from filepath.Walk, (the error in walk func will stop walk but will not be returned).

@mholt

mholt commented Oct 18, 2022

Copy link
Copy Markdown
Owner

@WeidiDeng Wow, you are right. I missed that too 😄

@nicola-spb

nicola-spb commented Oct 18, 2022 •

Copy link
Copy Markdown

@mholt Hi
Pull request fix it (check in Ubuntu and Win).

@mholt mholt left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you very much for the patch @WeidiDeng, and thanks to @nicola-spb for confirming.

@mholt
mholt merged commit 2822485 into mholt:master Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken Zip archive

3 participants

⌂ 换网址