You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Zip{} does not compress files without SelectiveCompression enabled #418
changed the title [-]Zip{} does not compress files without SelectiveCompression set [/-][+]Zip{} does not compress files without SelectiveCompression enabled [/+]on Aug 21, 2024
Enabling SelectiveCompression turns compression off for certain files.
This issue is a bug report - all files are not compressed withoutSelectiveCompression enabled.
I believe this happens because hdr.Method = z.Compression is only set in "if z.SelectiveCompression {}" clause. I think adding
Activity
[-]Zip{} does not compress files without SelectiveCompression set [/-][+]Zip{} does not compress files without SelectiveCompression enabled [/+]mholt commentedon Aug 21, 2024
What are the files (filenames at least)? Enabling
SelectiveCompressionturns compression off for certain files.hevav commentedon Aug 21, 2024
*.mca (minecraft chunk files).
This issue is a bug report - all files are not compressed without
SelectiveCompressionenabled.I believe this happens because
hdr.Method = z.Compressionis only set in "if z.SelectiveCompression {}" clause. I think addingshould help
mholt commentedon Aug 21, 2024
Ah I see!
Would you like to submit a pull request and get credited for the commit?
hevav commentedon Aug 21, 2024
See #419
mholt commentedon Aug 21, 2024
Thanks for the patch!