Skip to content

fix(Dockerfile):pack the static file into binary - #614

Merged
metrue merged 3 commits into
masterfrom
fix-packr-issue
Jun 8, 2021
Merged

metrue merged 3 commits into
masterfrom
fix-packr-issue

Conversation

@metrue

@metrue metrue commented Jun 8, 2021

Copy link
Copy Markdown
Owner

go get -u github.com/gobuffalo/packr/v2/packr2
packr2

Issue: #613
Summary: The static files had not been packed into binary.

The checklist before PR is ready for review:

  • has unit testing for new added codes
  • has functional testing for new added features
  • has checked the lint or style issues
  • README updated if need

metrue added 2 commits June 8, 2021 16:22
…ffalo/packr/v2/...

go get -u github.com/gobuffalo/packr/v2/packr2
packr2
@codecov

codecov Bot commented Jun 8, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #614 (066d4f5) into master (258f7bc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #614   +/-   ##
=======================================
  Coverage   22.19%   22.19%           
=======================================
  Files          55       55           
  Lines        1739     1739           
=======================================
  Hits          386      386           
  Misses       1272     1272           
  Partials       81       81           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 258f7bc...066d4f5. Read the comment docs.

@metrue
metrue merged commit 525e19b into master Jun 8, 2021
@metrue
metrue deleted the fix-packr-issue branch June 8, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址