Skip to content

v0.9.32 - #492

Merged
metrue merged 4 commits into
productionfrom
master
Mar 19, 2020
Merged

metrue merged 4 commits into
productionfrom
master

Conversation

@metrue

@metrue metrue commented Mar 19, 2020

Copy link
Copy Markdown
Owner

Issue:
Summary:

The checklist before PR is ready for review:

  • has unit testing for new added codes
  • has functional testing for new added features
  • has checked the lint or style issues
  • README updated if need

metrue added 4 commits March 18, 2020 09:00
* add --host and --kubeconf to `fx up`
* remove `fx infra list` and `fx infra use`
* put assets into skip dir for golangci

* fix lint issue

* upgrade go-ssh-client to consume the 'Connectable' API, enable more
friendly SSH connection error message

* parse 'host' and 'kubeconf' for `fx list` and `fx down` also

* refactor parse

* clean infra stuff
@codecov

codecov Bot commented Mar 19, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #492 into production will decrease coverage by 1.48%.
The diff coverage is 42.64%.

Impacted file tree graph

@@              Coverage Diff               @@
##           production     #492      +/-   ##
==============================================
- Coverage       25.91%   24.42%   -1.49%     
==============================================
  Files              63       55       -8     
  Lines            2335     1863     -472     
==============================================
- Hits              605      455     -150     
+ Misses           1615     1333     -282     
+ Partials          115       75      -40     
Impacted Files Coverage Δ
container_runtimes/docker/http/api.go 0.00% <0.00%> (ø)
context/context.go 71.42% <ø> (ø)
driver/k8s/configmap.go 0.00% <ø> (ø)
driver/k8s/deployer.go 0.00% <0.00%> (ø)
driver/k8s/deployment.go 0.00% <0.00%> (ø)
driver/k8s/init_container.go 0.00% <0.00%> (ø)
driver/k8s/k8s.go 0.00% <ø> (ø)
driver/k8s/k8s_node.go 0.00% <ø> (ø)
driver/k8s/pod.go 0.00% <ø> (ø)
driver/k8s/service.go 0.00% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7df1c64...ec49f75. Read the comment docs.

@metrue
metrue merged commit 29a3c7a into production Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址