Repository navigation
Ignore stale out-of-order promises in async bindings - #536
Open
dupontbertrand wants to merge 1 commit into
Open
dupontbertrand wants to merge 1 commit into
dupontbertrand wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #514.
When a reactive input driving an async helper (or an async HTML attribute) updates while a previous
Promiseis still pending, an earlier slower promise settling after a newer one could overwrite theReactiveVar(or DOM attributes) with a stale value or error.Change
packages/blaze/builtins.js: Track the activeautorungeneration in_createBinding(latestRun) and pass anisCurrentguard (() => run === latestRun && !comp.stopped) to_setBindingValueso only the latest active run may write toreactiveVarwhen a promise resolves or rejects.packages/blaze/materializer.js: Apply the samelatestRunandupdaterComputation?.stoppedguard insideupdateAttributesbefore applying awaited attribute values.packages/spacebars-tests/async_tests.js: Add deterministic out-of-order promise resolution/rejection tests acrossdirect,state1(@pending/@resolved/@rejected),#if,#each..in,#with, and HTML attributes.Verification
Ran the headless Tinytest suite in
test-appboth without jQuery (native DOM backend) and with--extra-packages=jquery:432 / 0 / 0 / 432passed--extra-packages=jquery):436 / 0 / 0 / 436passedChangelog
blaze: Ignore stale out-of-order promises in async template bindings and attributes (Async helper binding keeps a stale result (out-of-order promise clobbers the latest value) #514).