Repository navigation
[Editorial review] Add BiDi network request lifecycle event pages - #46141
Conversation
|
Preview URLs (5 pages)
Flaws (18) Found an unexpected or unresolvable flaw? Please report it here. URL:
URL:
URL:
URL:
URL:
(comment last updated: 2026-11-20 12:33:19) |
1d84f82 to
c773441
Compare
c773441 to
6673f0b
Compare
juliandescottes
left a comment
There was a problem hiding this comment.
Thanks Vadim! Really nice to see those events being documented after spending so much time on the implementation.
Having the events lifecycle written down will be extremely helpful. I have a few comments so I'll send it back to you to take a look. I will try to re-review it faster.
(Sorry for the delay with those)
juliandescottes
left a comment
There was a problem hiding this comment.
(and I forgot to request changes here, sorry)
juliandescottes
left a comment
There was a problem hiding this comment.
Thanks for the updates, all my comments are addressed. Approving. One nit: in the fetch() example, the spec always sets top-level lineNumber/columnNumber on initiator, so you could add them to match the text below the example.
Also for the cookie size: the spec text says byte length of name=value, but browsers and wpt use name + value length, as in your example. That's a spec/test mismatch, so no change is needed here. I will file a spec issue for this. At the moment your doc matches the implementation, in case the spec issue results in updating the implementations (which I doubt) we would have to update this, but no reason to block for now.
|
Please loop in @sadym-chromium for compat sheet updates. |
Thanks! I added the top-level |
|
@dipikabh ready for your review! |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
* upstream/main: (204 commits) [Editorial review] Add BiDi `network.setCacheBehavior` and `network.setExtraHeaders` pages (mdn#46140) build(deps-dev): bump @mdn/fred from 2.10.1 to 2.11.0 (mdn#46474) Reorder sections on HTML attribute pages (mdn#46483) Reorder sections on HTML element pages (mdn#46484) Fix live sample code block order in web API pages (mdn#46452) Move SVG attribute usage notes after examples (mdn#46458) Move SVG attribute elements section before examples (mdn#46459) Fix SuppressedError nesting in the `using` error handling example (mdn#46479) Editorial review: Document Web Audio render quantum size (mdn#46241) Remove the SVGAnimateColorElement page (mdn#46473) FF161 Relnote: Move WebTransport.anticipatedConcurrentIncoming{Uni|Bi}directionalStreams from 160 (mdn#46440) [WebExt] Screenshot updates to Nova (mdn#46270) build(deps-dev): bump cspell from 10.4.0 to 10.4.1 in the npm-dev group (mdn#46455) Update Firefox 160 release notes for WebDriver conforming changes. (mdn#46415) ci(deps): bump peter-evans/create-pull-request from 8.1.1 to 8.1.2 (mdn#46454) Move subtitles_en.vtt to shared-assets and update audio-video reference (mdn#46451) Yank Express Application Generator, migrate Express tutorial to ESM (mdn#45596) Fix heading sequence in web-api property pages (mdn#46450) Fix heading sequence in web-api interface pages (mdn#46448) Fix heading sequence in css-property pages (mdn#46447) ... # Conflicts: # files/en-us/web/webdriver/reference/bidi/modules/network/index.md # files/sidebars/webdriver.yaml
|
Thanks! I applied all the suggestions on |
dipikabh
left a comment
There was a problem hiding this comment.
Review for the network.responseCompleted page.
dipikabh
left a comment
There was a problem hiding this comment.
Thanks a lot, Vadim, for this work. This is looking in great shape!
I have one reorganization comment for the overview page.
|
Thank you everyone! 🥳 |
Description
networkmodule:network.beforeRequestSentnetwork.fetchErrornetwork.responseCompletednetwork.responseStartednetworkmodule landing page.Every example was run against Firefox Nightly 159 and Chrome 155 (through ChromeDriver) with a local server.
Spec links
Related issue
Doc issue: mdn/mdn#851
Compat quirks worth looking into:
Firefox
errorTextonfetchErroras unsupported, but Nightly 159 sends it (NS_ERROR_UNKNOWN_HOST,NS_BINDING_ABORTED)./cc @whimboo for the compat sheet update.
Chrome
userContextas unsupported, but Chrome 155 sends"default"./cc @sadym-chromium for the compat sheet update.