Repository navigation
fix(wasm playground): set ZSV_PROG_NAME env var in preRun - #684
Merged
Merged
Conversation
Signed-off-by: Azeem Sajid <azeem.sajid@gmail.com>
ZSV_PROG_NAME env var in preRunZSV_PROG_NAME env var in preRun
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed unwanted
this.programstrings in the playground:Fixed by setting
ZSV_PROG_NAME=zsvonpreRun.Also, moved sample CSV file created to
preRun.emscripten
Module.preRun: https://emscripten.org/docs/api_reference/module.html#Module.preRunSigned-off-by: Azeem Sajid azeem.sajid@gmail.com