Skip to content

Make simul form options translatable - #22473

Open
slick-daddy wants to merge 5 commits into
lichess-org:masterfrom
slick-daddy:simul18
Open

slick-daddy wants to merge 5 commits into
lichess-org:masterfrom
slick-daddy:simul18

Conversation

@slick-daddy

Copy link
Copy Markdown
Contributor

Replace hardcoded English strings in simul new form (color, clock time, increment, extra time options) with translation keys using existing i18n pattern.

@slick-daddy
slick-daddy marked this pull request as draft November 11, 2026 11:06
@slick-daddy
slick-daddy force-pushed the simul18 branch 3 times, most recently from 66a5fc3 to 898d536 Compare November 12, 2026 11:45
Replace hardcoded English strings in simul new form (color, clock time, increment, extra time options) with translation keys using existing i18n pattern.
@slick-daddy
slick-daddy marked this pull request as ready for review November 12, 2026 12:12
@slick-daddy
slick-daddy marked this pull request as draft November 12, 2026 12:12
@slick-daddy
slick-daddy marked this pull request as ready for review November 12, 2026 12:19
@ornicar

ornicar commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

this is very low priority as it's only seen by simul hosts

@slick-daddy

Copy link
Copy Markdown
Contributor Author

Fair but PR adds around 15 getters and they are easy to translate. So I am keeping this open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址