Repository navigation
Make simul form options translatable - #22473
Open
slick-daddy wants to merge 5 commits into
Open
slick-daddy wants to merge 5 commits into
slick-daddy wants to merge 5 commits into
Conversation
slick-daddy
marked this pull request as draft
November 11, 2026 11:06
slick-daddy
force-pushed
the
simul18
branch
3 times, most recently
from
November 12, 2026 11:45
66a5fc3 to
898d536
Compare
Replace hardcoded English strings in simul new form (color, clock time, increment, extra time options) with translation keys using existing i18n pattern.
slick-daddy
marked this pull request as ready for review
November 12, 2026 12:12
slick-daddy
marked this pull request as draft
November 12, 2026 12:12
slick-daddy
marked this pull request as ready for review
November 12, 2026 12:19
Collaborator
|
this is very low priority as it's only seen by simul hosts |
Contributor
Author
|
Fair but PR adds around 15 getters and they are easy to translate. So I am keeping this open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded English strings in simul new form (color, clock time, increment, extra time options) with translation keys using existing i18n pattern.