Skip to content

Make getting the up-time more portable across unix-like systems - #326

Merged
liamg merged 3 commits into
liamg:mainfrom
qiu-x:fbsd
Dec 17, 2021
Merged

liamg merged 3 commits into
liamg:mainfrom
qiu-x:fbsd

Conversation

@qiu-x

@qiu-x qiu-x commented Nov 6, 2021

Copy link
Copy Markdown
Contributor

This fixes #324

@qiu-x

qiu-x commented Nov 14, 2021

Copy link
Copy Markdown
Contributor Author

@liamg

@qiu-x

qiu-x commented Nov 14, 2021 •

Copy link
Copy Markdown
Contributor Author

From https://pkg.go.dev/cmd/go#hdr-Build_constraints:

Go versions 1.16 and earlier used a different syntax for build constraints, with a "// +build" prefix. The gofmt command will add an equivalent //go:build constraint when encountering the older syntax.

I suggest updating the Go version used in the checks. For now I will change my fix to use the old syntax.

Edit: Never mind, that would be a pretty bad solution since the new Go version does not support the old syntax, so the build would fail on new versions. So the best way to fix the errors in the checks is updating Go

@liamg
liamg merged commit 97b6a41 into liamg:main Dec 17, 2021
@qiu-x
qiu-x deleted the fbsd branch December 17, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build fails: undefined: syscall.Sysinfo_t

2 participants

⌂ 换网址