Repository navigation
Closed
Labels
kind/api-changeCategorizes issue or PR as related to adding, removing, or otherwise changing an APICategorizes issue or PR as related to adding, removing, or otherwise changing an APIkind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.sig/appsCategorizes an issue or PR as relevant to SIG Apps.Categorizes an issue or PR as relevant to SIG Apps.sig/nodeCategorizes an issue or PR as relevant to SIG Node.Categorizes an issue or PR as relevant to SIG Node.stage/stableDenotes an issue tracking an enhancement targeted for Stable/GA statusDenotes an issue tracking an enhancement targeted for Stable/GA status
Milestone
Description
Enhancement Description
- One-line enhancement description (can be used as a release note): Kubernetes introduces the built-in support for sidecar containers pattern.
- Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/753-sidecar-containers/README.md
- Discussion Link: Sidecar working group and KEP draft
- Primary contact (assignee): @SergeyKanzhelev
- Responsible SIGs: node
- Enhancement target (which target equals to which milestone):
- Alpha release target (x.y): 1.28
- Beta release target (x.y): 1.29
- Stable release target (x.y): 1.33
- Alpha
- KEP (
k/enhancements) update PR(s): - Code (
k/k) update PR(s): - Docs (
k/website) update PR(s):
- KEP (
- Beta
- KEP (
k/enhancements) update PR(s): KEP-753: add PRR questionnaire answers for beta #4255 - Code (
k/k) update PR(s): - Docs (
k/website) update(s): Document SidecarContainers graduation to beta website#43471
- KEP (
- Stable
- KEP (
k/enhancements) update PR(s): - Code (
k/k) update PR(s): Promote SidecarContainers feature to GA kubernetes#129731 - Docs (
k/website) update(s): update SidecarContainers to stable in v1.33 website#49685
- KEP (
/sig node
Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
Reacted by Pablo Javier Marti, Maxime Guyot, Kent Rancourt, Vladimir Dimitrov, Itay Shakury, bhack, Nicolas Moser, Joseph (Jy) Yaworski, Laurentiu Badea, Antti Nevala and 380 more
Reacted by sakajunquality, Michael Haddon, Zelin L, Katsuya Kawabe, Tariq, ZY, Hong Shick Pak, Justin Lee, Nick Romaniuk, Gerson Carneiro and 6 more
Reacted by Paul Tiplady, bhack, Nicolas Moser, Joseph (Jy) Yaworski, Ryan Bezdicek, Kieren Johnstone, Shaw Ho, kolorful, Chuck Hagy, shaneqld and 55 more
Reacted by Anton Bessonov, André Cruz, Janos Roden, Dan Siviter, Shinichi TAMURA, Koen van den Heuvel, vova-deimos, felixcontant, Simon Kerler, William Zhang and 106 more
Reacted by Nikita, Max, Decebal Dobrica, Gregory Vander Schueren, Jens Fosgerau, Kornelijus, BrettMayson, Naseem, sakajunquality, Tomasz Klosinski and 23 more
Reacted by Tim Downey, Sandor Szücs, doctorsnail, Naseem, sakajunquality, Tomasz Klosinski, Ankit Adarsh, Michael Haddon, Tariq, Justin Lee and 14 more
Metadata
Metadata
Assignees
Labels
kind/api-changeCategorizes issue or PR as related to adding, removing, or otherwise changing an APICategorizes issue or PR as related to adding, removing, or otherwise changing an APIkind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.sig/appsCategorizes an issue or PR as relevant to SIG Apps.Categorizes an issue or PR as relevant to SIG Apps.sig/nodeCategorizes an issue or PR as relevant to SIG Node.Categorizes an issue or PR as relevant to SIG Node.stage/stableDenotes an issue tracking an enhancement targeted for Stable/GA statusDenotes an issue tracking an enhancement targeted for Stable/GA status
Type
Projects
- StatusShow more project fieldsClosed
- StatusShow more project fieldsRemoved From Milestone
- StatusShow more project fieldsTracked
- StatusShow more project fieldsTracked for Code Freeze
- StatusShow more project fieldsNot for release
- StatusShow more project fieldsTracked for Docs Freeze
- StatusShow more project fieldsDone
Activity
Joseph-Irving commentedon Jan 29, 2019
@enisoc @dchen1107 @fejta @thockin @kow3ns @derekwaynecarr, opened this tracking issue so that we can discuss.
kow3ns commentedon Jan 31, 2019
/assign
Joseph-Irving commentedon Feb 1, 2019
@derekwaynecarr I've done some scoping out of the kubelet changes required for next week's sig-node meeting, I believe that changes are only needed in the
kuberuntimepackage, specificallykuberuntime_manager.goin andkuberuntime_container.go.In
kuberuntime_manager.goyou could modifycomputePodActionsto implement the shutdown triggering (kill sidecars when all non-sidecars have permanently exited), and starting up the sidecars first.In
kuberuntime_container.goyou could modifykillContainersWithSyncResultfor terminating the sidecars last and sending the preStop hooks (the preStop hooks bit was a bit debatable, it wasn't settled whether that should be done or not. @thockin had a good point about why you might not want to encourage that behaviour, see comment).Let me know if you want me to investigate any further.
resouer commentedon Feb 1, 2019
@kow3ns The discussion makes more sense to me if maybe we can define a full description of containers sequence in Pod spec (sig-app), and how to handle the sequence in kubelet for start, restart and cascading consideration (sig-node). Let's catch the Feb 5 sig-node meeting to give more inputs.
cc @Joseph-Irving
luksa commentedon Feb 7, 2019
The proposal says that sidecars only run after the init containers run. But what if the use-case requires the sidecar to run while/before the init containers run. For example, if you'd like route the pod's traffic through a proxy running as a sidecar (as in Istio), you probably want that proxy to be in place while the init containers run in case the init container itself does network calls.
Joseph-Irving commentedon Feb 14, 2019
@luksa I think there's the possibility of looking at having sidecars that run in init phase at some point but currently the proposal is not going to cover that use case. There is currently no way to have concurrent containers running in the init phase so that would be potentially a much larger/messier change than what is being suggested here.
Joseph-Irving commentedon Feb 14, 2019
Update on this KEP:
I've spoken to both @derekwaynecarr and @dchen1107 from sig-node about this and they did not express any major concerns about the proposal. I will raise a PR to the KEP adding some initial notes around implementation details and clarifying a few points that came up during the discussion.
We still need to agree on the API, it seems there is consensus that a simple way of marking containers as sidecars is prefered over more in depth ordering flags. Having a bool is somewhat limiting though so perhaps something more along the lines of
containerLifecycle: Sidecarwould be preferable so that we have the option of expanding in the future.luksa commentedon Feb 14, 2019
@Joseph-Irving Actually, neither the boolean nor the
containerLifecycle: Sidecarare appropriate for proper future extensibility. Instead,containerLifecycleshould be an object, just likedeployment.spec.strategy, withtype: Sidecar. This would allow us to then introduce additional fields. For the "sidecar for the whole lifetime of the pod" solution, it would be expressed along these lines:as opposed to
Please forgive my bad naming - I hope the names convey the idea.
But there is one problem with the approach where we introduce
containerLifecycletopod.spec.containers. Namely, it's wrong to have sidecars that run parallel to init containers specified underpod.spec.containers. So if you really want to be able to extend this to init containers eventually, you should find an alternative solution - one that would allow you to mark containers as sidecars at a higher level - i.e. not underpod.spec.containersorpod.spec.initContainers, but something likepod.spec.sidecarContainers, which I believe you already discussed, but dismissed. The init containers problem definitely calls for a solution along these lines.Joseph-Irving commentedon Feb 14, 2019
@luksa You could also solve the init problem by just allowing an init container to be marked as a sidecar and have that run alongside the init containers. As I understand it, the problem is that init containers sometimes need sidecars, which is different from needing a container that runs for the entire lifetime of the pod.
The problem with
pod.spec.sidecarContainersis that it's a far more complex change, tooling would need to updated and the kubelet would require a lot of modifying to support another set of containers. The current proposal is far more modest, it's only building on what's already there.324 remaining items
dipesh-rawat commentedon Mar 18, 2025
Hi @SergeyKanzhelev @Joseph-Irving 👋, v1.33 Enhancements team here,
I see this KEP is
tracked for code freezewith the required PR for stable graduation merged. I noticed there are some concerns/discussions around the graduation of this KEP (refer #753 (comment) and kubernetes/kubernetes#127701) . With code freeze deadline later this week, could we please confirm if this KEP is still planned for stable graduation and targeting this v1.33 release cycle, so the release team can ensure accurate status tracking?Thanks!
jenshu commentedon May 16, 2025
Hi @SergeyKanzhelev 👋, 1.34 Enhancements Lead here,
Given that this KEP has graduated to
stableand the status inkep.yamlhas been updated toimplemented, I will close the issue./remove-label lead-opted-in
/remove-label tracked/yes
/close
k8s-ci-robot commentedon May 16, 2025
@jenshu: Closing this issue.
Details
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[SPARK-54780][K8S][DOCS] Drop K8s v1.32 Support
[SPARK-54788] Upgrade the minimum K8s version to v1.33