Repository navigation
Handle more resource kind health status - #662
Merged
undera merged 1 commit intoMar 17, 2026
Merged
Conversation
…espace Add condition-based health status calculation for additional resource kinds: - ExternalSecret: checks "Ready" condition - Job: checks "Complete" and "Failed" conditions - HorizontalPodAutoscaler: checks "AbleToScale" and "ScalingActive" conditions - Namespace: handles "Terminating" phase as Progressing Closes komodorio#418 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
Nice and clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Readycondition)CompleteandFailedconditions)AbleToScaleandScalingActiveconditions)Terminatingphase as Progressing -Activephase was already supported)All new conditions follow the existing pattern in
applyCustomConditions, guarded byc.Status == Unknownto avoid overriding higher-priority conditions.Closes #418
Test plan
go vet ./pkg/dashboard/handlers/passesgo test ./pkg/dashboard/handlers/ -v- all 8 new tests pass