Skip to content

Handle more resource kind health status - #662

Merged
undera merged 1 commit into
komodorio:mainfrom
mvanhorn:feat/additional-resource-health-status
Mar 17, 2026
Merged

undera merged 1 commit into
komodorio:mainfrom
mvanhorn:feat/additional-resource-health-status

Conversation

@mvanhorn

Copy link
Copy Markdown
Contributor

Summary

  • Add health status calculation for ExternalSecret (checks Ready condition)
  • Add health status calculation for Job (checks Complete and Failed conditions)
  • Add health status calculation for HorizontalPodAutoscaler (checks AbleToScale and ScalingActive conditions)
  • Add health status calculation for Namespace (handles Terminating phase as Progressing - Active phase was already supported)
  • Add unit tests covering all new resource kind health status paths

All new conditions follow the existing pattern in applyCustomConditions, guarded by c.Status == Unknown to avoid overriding higher-priority conditions.

Closes #418

Test plan

  • go vet ./pkg/dashboard/handlers/ passes
  • go test ./pkg/dashboard/handlers/ -v - all 8 new tests pass
  • Deploy and verify health status icons appear for ExternalSecret, Job, HPA, and Namespace resources in the helm release resource list

…espace

Add condition-based health status calculation for additional resource kinds:
- ExternalSecret: checks "Ready" condition
- Job: checks "Complete" and "Failed" conditions
- HorizontalPodAutoscaler: checks "AbleToScale" and "ScalingActive" conditions
- Namespace: handles "Terminating" phase as Progressing

Closes komodorio#418

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@undera

undera commented Mar 17, 2026

Copy link
Copy Markdown
Collaborator

Nice and clean.
The cyclomatic complexity needs to be solved separately

@undera
undera merged commit f857f8d into komodorio:main Mar 17, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle more resource kind health status

2 participants

⌂ 换网址