Repository navigation
fix: maintain cluster context after adding repo (#616) - #641
Merged
Merged
Conversation
undera
requested changes
Jan 8, 2026
undera
left a comment
Collaborator
There was a problem hiding this comment.
Since you did not change dependencies - rollback lock file changes
Contributor
Author
|
I've updated the PR to remove the lock file changes. Please let me know if there are any other adjustments you'd like me to make! Happy to help. |
Collaborator
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Proposed
Changes Proposed
This PR resolves Issue #616 where the application lost the cluster context after a user added a new repository.
The Problem: After a successful repository addition, the app redirected to
/#/repository/<name>instead of/#/<cluster>/repository/<name>. This caused a "cluster unreachable: context undefined" error when the user navigated away and back, as the routing state became corrupted.The Fix:
Header Navigation: Updated Header.tsx to use the new prefixed path logic. This ensures that clicking the "Installed" or "Repository" tabs always maintains the active cluster context in the URL, preventing the app from falling into an "undefined" state.
Centralized Routing Logic: Updated LinkWithSearchParams.tsx to automatically handle cluster prefixing based on the active context and clusterMode state.
Modal Navigation Fix: Modified AddRepositoryModal.tsx to ensure the post-success redirect includes the current cluster context.
Ingress Stability: Standardized navigation to use absolute-style paths (starting with /). Since we use HashRouter, these are absolute to the hash root, ensuring the app remains stable when hosted on sub-paths.
Closes #616
Check List