Skip to content

Refactor Persistent Volume Configuration - #565

Merged
undera merged 1 commit into
komodorio:mainfrom
unitmatrix:fix/pvc-issue
Dec 2, 2024
Merged

undera merged 1 commit into
komodorio:mainfrom
unitmatrix:fix/pvc-issue

Conversation

@unitmatrix

Copy link
Copy Markdown
Contributor

This pull request introduces several changes to the persistent volume configuration in the Helm Dashboard chart, addressing concerns raised in GitHub issue #221. Key updates include:

  1. Removal of hostPath configuration: The hostPath parameter has been removed from the configuration to discourage its use in production environments. This change aligns with best practices for production deployments, which typically avoid local host path volumes due to security and reliability concerns.

  2. Introduction of finalizers: Added the kubernetes.io/pvc-protection finalizer to Persistent Volume Claims to prevent their deletion until associated resources are properly cleaned up. This ensures that data persistence is managed safely across the lifecycle of the resources.

  3. Dynamic volume name lookup: Implemented a conditional lookup for existing volume names using the lookupVolumeName parameter. This feature dynamically fetches and applies the volume name during Persistent Volume Claim creation if the volume already exists, improving the management of volume names and reducing manual errors.

  4. Commented out the storageClass parameter: The default storageClass is now commented out to promote the use of default provisioners unless explicitly specified by the user. This change simplifies the configuration for users who are content with default provisioning options.

  5. Removal of the PersistentVolume declaration: The entire declaration for PhysicalVolume has been dropped to streamline the configuration. Since the chart is expected to be used with dynamic volume provisioning (or existing PVC setups), defining a static PersistentVolume is redundant and could lead to configuration conflicts. This simplifies the deployment process and reduces the need for manual volume management.

These changes not only address the issues discussed in issue #221 but also enhance the robustness of volume management within the Helm Dashboard, aligning persistent storage configurations with best practices.

@undera

undera commented Dec 2, 2024

Copy link
Copy Markdown
Collaborator

Thank you very much for addressing it!

@undera
undera merged commit e5e15f9 into komodorio:main Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址