Skip to content

Fix: Handle Cluster Names with Slashes in Helm Dashboard UI - #563

Merged
undera merged 1 commit into
komodorio:mainfrom
unitmatrix:fix/conntent-decoding
Nov 26, 2024
Merged

undera merged 1 commit into
komodorio:mainfrom
unitmatrix:fix/conntent-decoding

Conversation

@unitmatrix

Copy link
Copy Markdown
Contributor

This PR addresses issue #557 by ensuring that the Helm Dashboard UI is accessible even if the cluster name contains a slash. The changes include:

  • Added necessary encoding to the navigation path to prevent routing issues.
  • Implemented decoding of cluster names to ensure proper display and functionality.

Closes #557.

remove redundant code

correct encode decode
@undera

undera commented Nov 26, 2024

Copy link
Copy Markdown
Collaborator

This is very nice! Thank you!

@undera
undera merged commit 69fe906 into komodorio:main Nov 26, 2024
@unitmatrix
unitmatrix deleted the fix/conntent-decoding branch December 2, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm Dashboard UI not accessible if cluster name contains slash

2 participants

⌂ 换网址