Skip to content

Update helm-dashboard.serviceAccountName Template Logic in _helpers.tpl - #561

Merged
undera merged 1 commit into
komodorio:mainfrom
unitmatrix:optimize-service-account-name-definition
Nov 22, 2024
Merged

undera merged 1 commit into
komodorio:mainfrom
unitmatrix:optimize-service-account-name-definition

Conversation

@unitmatrix

Copy link
Copy Markdown
Contributor

This pull request updates the helm-dashboard.serviceAccountName template logic in the _helpers.tpl file to improve the handling of service account names. The changes include:

  • Utilizing the default function to set the service account name based on the serviceAccount.create value.
  • Ensuring that the service account name is generated using the helm-dashboard.fullname template when serviceAccount.create is true, otherwise defaulting to "default".
  • Maintaining backward compatibility with existing configurations by preserving the use of .Values.serviceAccount.name.

These changes enhance the flexibility and robustness of the Helm chart's service account naming conventions.

@undera
undera merged commit 922bb1c into komodorio:main Nov 22, 2024
@unitmatrix
unitmatrix deleted the optimize-service-account-name-definition branch November 22, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址