Repository navigation
update helm charts for helm-dashboard - #490
Merged
Merged
Conversation
1. fix `imagePullSecrets` bug in deployment.yaml 2. add `global` config 3. optimize image field with global registry config
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
imagePullSecretsbug in deployment.yamlglobalconfigChanges Proposed
this pr is for charts of helm-dashboard
fix

imagePullSecretsbug in deployment.yamlif use old deployment.yaml it will reported that e
expect map but get stringadd
globalconfigbusybox image is hard code in the charts, so i propose to use
global.imageRegistryto unify render of image. same withimagePullSecretsCheck List