Skip to content

Improved revision block for long numbers - #473

Merged
undera merged 2 commits into
komodorio:mainfrom
SD007CSE:Fix-#468
Sep 27, 2023
Merged

undera merged 2 commits into
komodorio:mainfrom
SD007CSE:Fix-#468

Conversation

@SD007CSE

@SD007CSE SD007CSE commented Sep 27, 2023 •

Copy link
Copy Markdown
Contributor

Changes Proposed

Fixes #468.

I have fixed the issue of long numbers in the Revision Block.

Before
Before

After
After

Check List

  • The title of my pull request is a short description of the changes
  • This PR relates to some issue:
  • I have documented the changes made (if applicable)
  • I have covered the changes with unit tests

@undera undera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my comment

Comment thread frontend/yarn.lock Outdated
resolved "https://registry.npmjs.org/fs.realpath/-/fs.realpath-1.0.0.tgz"
integrity sha512-OO0pH2lK6a0hZnAdau5ItzHPI6pUlvI7jMVnxUQRtw4owF2wk8lOSabtGDCTP4Ggrg2MbGnWO9X8K1t4+fGMDw==

fsevents@^2.3.2, fsevents@~2.3.2:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably unintentional addition, not related to the fix. Please remove it.

@SD007CSE SD007CSE Sep 27, 2023 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@SD007CSE
SD007CSE requested a review from undera September 27, 2023 18:01
@undera

undera commented Sep 27, 2023

Copy link
Copy Markdown
Collaborator

Thank you very much!

@undera
undera merged commit 88ea89a into komodorio:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve revision block for long numbers

2 participants

⌂ 换网址