Skip to content

Doc features: Multicluster - #352

Merged
undera merged 4 commits into
komodorio:mainfrom
pushker001:doc
May 8, 2023
Merged

undera merged 4 commits into
komodorio:mainfrom
pushker001:doc

Conversation

@pushker001

@pushker001 pushker001 commented May 5, 2023 •

Copy link
Copy Markdown
Contributor

Helps the user to switch to a different cluster
#255

Check List

  • The title of my pull request is a short description of the changes
  • This PR relates to some issue:

Helps the user to switch to a different cluster.

@undera undera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes:

  1. Crop screenshot, so there's no huge empty space at the bottom. Also, top side of screenshot is cut in the middle of panel & logo. Either make whole panel & logo visible, or crop it off. Generally, when doing screenshot, think that it is meant to help user locate the element that you describe. For that you need to give some context. So it's better to make screenshot with sufficient surrounding. To summarize, this screenshot should contain full top panel, for context.
  2. It's good to add a bit of explanation how this multi-cluster is defined. I mean explaining that the list of clusters comes from kubeconfig. Finding and adding a hyperlink to appropriate k8s doc (https://kubernetes.io/docs/tasks/access-application-cluster/configure-access-multiple-clusters/ in this case) would let reader to continue learning, if needed.

@undera
undera merged commit d225924 into komodorio:main May 8, 2023
@pushker001
pushker001 deleted the doc branch May 8, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址