Repository navigation
Doc features: Multicluster - #352
Merged
Merged
Conversation
Helps the user to switch to a different cluster.
undera
requested changes
May 5, 2023
undera
left a comment
Collaborator
There was a problem hiding this comment.
A few notes:
- Crop screenshot, so there's no huge empty space at the bottom. Also, top side of screenshot is cut in the middle of panel & logo. Either make whole panel & logo visible, or crop it off. Generally, when doing screenshot, think that it is meant to help user locate the element that you describe. For that you need to give some context. So it's better to make screenshot with sufficient surrounding. To summarize, this screenshot should contain full top panel, for context.
- It's good to add a bit of explanation how this multi-cluster is defined. I mean explaining that the list of clusters comes from kubeconfig. Finding and adding a hyperlink to appropriate k8s doc (https://kubernetes.io/docs/tasks/access-application-cluster/configure-access-multiple-clusters/ in this case) would let reader to continue learning, if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps the user to switch to a different cluster
#255
Check List