Skip to content

Doc Features: Application shutdown - #347

Merged
undera merged 3 commits into
komodorio:mainfrom
pushker001:DOcs
Apr 27, 2023
Merged

undera merged 3 commits into
komodorio:mainfrom
pushker001:DOcs

Conversation

@pushker001

@pushker001 pushker001 commented Apr 25, 2023 •

Copy link
Copy Markdown
Contributor

Begin documenting application features with describing application shutdown.

@pushker001 pushker001 changed the title Docs: To know to capability of application Docs: To know the capability of application Apr 25, 2023
@undera

undera commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

Please save the screenshot into images directory and reference it from doc, instead of third-party location.

Also, care about readers and make sure your English is more or less correct. Use ChatGPT for help, if needed:
Selection_001

@undera undera changed the title Docs: To know the capability of application Doc Features: Application shutdown Apr 26, 2023
@undera

undera commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

Note how I changed the title and description of PR to match the meaning of the changes more precisely.

Also, about the screenshot: avoid too much drawing on it. Simple arrow is enough to point to object. Sometimes when you want to outline large block, use simple rectangle, not circle. Small objects don't need rectangles at all.

Overall, this PR goes into right direction now. Thank you!

Please address my comments above to finalize it.

@undera

undera commented Apr 27, 2023

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! It's a good first step to document the application features.

@undera
undera merged commit 30eb209 into komodorio:main Apr 27, 2023
@pushker001
pushker001 deleted the DOcs branch April 27, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址