Skip to content

Display resource health aggregate icons on list of releases - #235

Merged
undera merged 7 commits into
mainfrom
resource-health-aggregate
Mar 13, 2023
Merged

undera merged 7 commits into
mainfrom
resource-health-aggregate

Conversation

@undera

@undera undera commented Mar 9, 2023 •

Copy link
Copy Markdown
Collaborator

Changes Proposed

Check List

  • The title of my pull request is a short description of the changes
  • This PR relates to some issue:
  • I have documented the changes made (if applicable)
  • I have covered the changes with unit tests

res.Status.Phase = "Not" + res.Status.Phase
if s.Phase == "Error" {
c.Status = Unhealthy
} else if slices.Contains([]string{"Available", "Active", "Established", "Bound", "Ready"}, string(s.Phase)) {

@harshit-mehtaa harshit-mehtaa Mar 10, 2023 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to move the list of state to a constant

@undera

undera commented Mar 12, 2023 •

Copy link
Copy Markdown
Collaborator Author

We need to choose from two variants of visualizing resource health:
Selection_001 (1)

or

Selection_001

@harshit-mehtaa

Copy link
Copy Markdown
Contributor

2nd one seems better

@undera
undera merged commit 57d4d07 into main Mar 13, 2023
@undera
undera deleted the resource-health-aggregate branch March 13, 2023 12:56
chad11111 pushed a commit that referenced this pull request Mar 18, 2023
* Increment chart versions [skip ci]

* Minor UI fixes (#234)

* Add username and password support to Repo add feature (#228)

* Add username and password support to Repo add in UI

* Add support for Username and Passowrd in Add Repo API

* Display resource health aggregate icons on list of releases (#235)

* Display aggregate resource health status

* Reuse old API request, show icons

* Take progress indication from deployment conditions

* Improve status

* Cleanup

* Fixups

* Squares approach

* Improve console message in case no k8s connection possible

* Count API docs in user analytics

* Create first Generic Modal + add storybook script

* change default modal button style

* Create anum for button styles

* fix type in console log

* Make the title completely customizable

* change story name

* Make the title optional

* implement auto scroll when height bigger than 500

* fix story example

* Change buttons in modal stories

* fix type

* Revert "Merge branch 'komodorio:main' into create-an-empty-global-modal"

This reverts commit e6aae0b, reversing
changes made to e37c6fe.

* Add className prop for fully customization

* Change buttonStyle to variant

* add id to ModalAction

* Add modal to portal div

* Add background with opacity

* change from type to interface

* fix modal margin

* Add it for the modal storybook

---------

Co-authored-by: komodor-bot <komi@komodor.io>
Co-authored-by: Harshit Mehta <hdm23061993@gmail.com>
Co-authored-by: Andrey Pokhilko <andrei.pokhilko@gmail.com>
chad11111 pushed a commit that referenced this pull request Mar 19, 2023
* Increment chart versions [skip ci]

* Minor UI fixes (#234)

* Add username and password support to Repo add feature (#228)

* Add username and password support to Repo add in UI

* Add support for Username and Passowrd in Add Repo API

* Display resource health aggregate icons on list of releases (#235)

* Display aggregate resource health status

* Reuse old API request, show icons

* Take progress indication from deployment conditions

* Improve status

* Cleanup

* Fixups

* Squares approach

* Improve console message in case no k8s connection possible

* Count API docs in user analytics

* Removing redundant table header (#268)

* update README (#270)

* Skeleton for Install Modal

* Revert "Merge branch 'komodorio:main' into Implement-install-modal-skeleton"

This reverts commit f731e6f, reversing
changes made to 6d90d43.

* some little fixes

* Fix modal pushed down bug

---------

Co-authored-by: komodor-bot <komi@komodor.io>
Co-authored-by: Harshit Mehta <hdm23061993@gmail.com>
Co-authored-by: Andrey Pokhilko <andrei.pokhilko@gmail.com>
aman1376 pushed a commit to aman1376/helm-dashboard that referenced this pull request Mar 24, 2023
* Increment chart versions [skip ci]

* Minor UI fixes (komodorio#234)

* Add username and password support to Repo add feature (komodorio#228)

* Add username and password support to Repo add in UI

* Add support for Username and Passowrd in Add Repo API

* Display resource health aggregate icons on list of releases (komodorio#235)

* Display aggregate resource health status

* Reuse old API request, show icons

* Take progress indication from deployment conditions

* Improve status

* Cleanup

* Fixups

* Squares approach

* Improve console message in case no k8s connection possible

* Count API docs in user analytics

* Create first Generic Modal + add storybook script

* change default modal button style

* Create anum for button styles

* fix type in console log

* Make the title completely customizable

* change story name

* Make the title optional

* implement auto scroll when height bigger than 500

* fix story example

* Change buttons in modal stories

* fix type

* Revert "Merge branch 'komodorio:main' into create-an-empty-global-modal"

This reverts commit e6aae0b, reversing
changes made to e37c6fe.

* Add className prop for fully customization

* Change buttonStyle to variant

* add id to ModalAction

* Add modal to portal div

* Add background with opacity

* change from type to interface

* fix modal margin

* Add it for the modal storybook

---------

Co-authored-by: komodor-bot <komi@komodor.io>
Co-authored-by: Harshit Mehta <hdm23061993@gmail.com>
Co-authored-by: Andrey Pokhilko <andrei.pokhilko@gmail.com>
chad11111 added a commit that referenced this pull request Mar 26, 2023
* init: project

* refactor (#236)

feat - liner

* vite init (#240)

* Create README.md

* Create README.md (#244)

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README (#250)

* Update README

Componenet library section

* Update dashboard/README.md

---------

Co-authored-by: chad11111 <127234894+chad11111@users.noreply.github.com>

* Update README.md

* Complib v0.0.5 (#254)

* Status Element

* added status and button

* Added revisionCard, and conditional rendering for version upgrade/downgrade and time since revision started.

* adding all changes before push

* Revisioning of revision card and of status

* Added refresh button to revision card

* Adding tabbar

* Extracted age logic in revisioncard component

* trying to get storybook to work and adding comments to revision card getRevisionAgeJSX auxiliary function.

* Configured storybook with a few samples

* Added info in Revision Card story, and showcased special badged.

* Added a special button example in storybook

* Easy Entry for storybook

* Response to review. extracted revisioncard props into an interface and created global.tsx for global types.
Added textinput.tsx and a story to display it.

* Removed unecessary css import.

* Corrected stories to enable passing interface props.

* refactored statuscode in Status.tsx

* Fixed props passing bug.

* Extracted getAge to timeUtils.

* Fixed BadgeProps

* Refactored stories.

* fixed bug in timeUtils.tsx

* Fixed problem with storybook. Now comps are showing.

* Reduced weird bloated package.json and made sure story-book still works.

* Refactor (#256)

* Update README.md

* Create an empty global modal (#253)

* Increment chart versions [skip ci]

* Minor UI fixes (#234)

* Add username and password support to Repo add feature (#228)

* Add username and password support to Repo add in UI

* Add support for Username and Passowrd in Add Repo API

* Display resource health aggregate icons on list of releases (#235)

* Display aggregate resource health status

* Reuse old API request, show icons

* Take progress indication from deployment conditions

* Improve status

* Cleanup

* Fixups

* Squares approach

* Improve console message in case no k8s connection possible

* Count API docs in user analytics

* Create first Generic Modal + add storybook script

* change default modal button style

* Create anum for button styles

* fix type in console log

* Make the title completely customizable

* change story name

* Make the title optional

* implement auto scroll when height bigger than 500

* fix story example

* Change buttons in modal stories

* fix type

* Revert "Merge branch 'komodorio:main' into create-an-empty-global-modal"

This reverts commit e6aae0b, reversing
changes made to e37c6fe.

* Add className prop for fully customization

* Change buttonStyle to variant

* add id to ModalAction

* Add modal to portal div

* Add background with opacity

* change from type to interface

* fix modal margin

* Add it for the modal storybook

---------

Co-authored-by: komodor-bot <komi@komodor.io>
Co-authored-by: Harshit Mehta <hdm23061993@gmail.com>
Co-authored-by: Andrey Pokhilko <andrei.pokhilko@gmail.com>

* skeleton for helm-dashboard-v2 (#266)

* skeleton for helm-dashboard-v2

* made-necessary changes

* Shut down modal

* made ncessary changes

* ShutDownModal

---------

Co-authored-by: chad11111 <127234894+chad11111@users.noreply.github.com>
Co-authored-by: Tony Stark <sz.unsc@gmail.com>
Co-authored-by: Nir Parisian <nir2002@users.noreply.github.com>
Co-authored-by: Erez Birenholz <biran330@gmail.com>
Co-authored-by: komodor-bot <komi@komodor.io>
Co-authored-by: Harshit Mehta <hdm23061993@gmail.com>
Co-authored-by: Andrey Pokhilko <andrei.pokhilko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址