Repository navigation
fix(mcp): drop invoke_agent's top-level oneOf so Gemini accepts it - #3534
Merged
Merged
Conversation
Signed-off-by: JR Camou <3706614+jotacamou@users.noreply.github.com>
EItanya
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3533
Removes the top-level
oneOffrominvoke_agent's input schema. Gemini rejects it, so every request from an agent that binds the tool fails. The schema is now inferred fromInvokeAgentInputlike the other tools. The handler already rejects calls with neither or both ofsession_idandagent.Tests:
TestToolSchemasHaveNoTopLevelCombinators: no core MCP tool schema has a top-leveloneOf,anyOforallOf. Fails onmain, passes here.TestInvokeAgentRejectsInvalidTargetsstill passes.make lint LINT_ARGS=./core/internal/mcp/...: 0 issues.