Repository navigation
feat(models): suggest current Foundry Grok model IDs - #3513
Merged
Merged
Conversation
The Foundry picker only listed grok-3. Microsoft Foundry now publishes grok-4.7 and the other Grok 4 deployment names. Signed-off-by: jay vyas <jay@apache.org> Co-authored-by: Cursor <cursoragent@cursor.com>
EItanya
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grok-3. Add the Grok model IDs Microsoft Foundry currently publishes, includinggrok-4.7, and keepgrok-3for existing deployments.grok-5is not a published Foundry model ID, so it is not added.Fixes #3512
Test plan
go test ./core/internal/service/model/ -run TestDiscoveryStaticModelCatalog -count=1asserts each published ID is in the Foundry catalog and thatgrok-5is absent.go test ./adk/pkg/models/ -run TestFoundryGrok47DeploymentIsCallableLocally -count=1serves a local chat completion for deploymentgrok-4.7and checks the request path. This does not call Azure or xAI.https://api.x.ai/v1/modelswith no key returns 401unauthenticated:no-credentials. No Foundry or xAI key is available here, so a live completion was not run.Made with Cursor