[EItanya]

Summary

• persist the immutable compiled Agent Card on each runtime revision
• serve authenticated extended Agent Cards from the AgentInstance pinned revision
• advertise the gateway gRPC endpoint through Helm configuration
• persist cancellation results before returning them
• serve terminal subscriptions from PostgreSQL and commit live subscription updates before publishing

The public .well-known/agent-card.json routing contract, authorization coverage, and new lifecycle tests remain deferred.

Validation

• go test ./core/v2/a2agateway
• make -C go lint
• focused Go race tests for gateway, database, controller, and controller-v2 before the follow-up
• Helm controller tests (58 passed)
• git diff --check

[Copilot]

Pull request overview

This PR adds persisted, revision-pinned Agent Cards for AgentInstances by storing the compiled Agent Card JSON on each runtime_revision, exposing an authenticated “extended” Agent Card from the gateway based on the AgentInstance’s pinned revision, and making the gateway’s public gRPC URL configurable via Helm.

Changes:

• Add a new runtime_revision.agent_card JSONB column and plumb it through SQLC-generated queries/models and the Postgres client.
• Persist the compiled Agent Card JSON during v2 controller reconciliation and serve the authenticated extended Agent Card from the gateway using the AgentInstance’s PreparedRevision.
• Add controller.a2aGatewayUrl Helm value + templating and tests to advertise the gateway gRPC endpoint via A2A_GATEWAY_URL.

Reviewed changes

Copilot reviewed 14 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
helm/kagent/values.yaml	Adds controller.a2aGatewayUrl Helm value for the advertised public gateway URL.
helm/kagent/tests/controller-deployment_test.yaml	Adds Helm unit tests asserting A2A_GATEWAY_URL defaulting and overrides.
helm/kagent/templates/controller-configmap.yaml	Injects A2A_GATEWAY_URL into the controller ConfigMap.
helm/kagent/templates/_helpers.tpl	Adds kagent.a2aGatewayUrl helper to compute the advertised gateway URL.
go/core/v2/controller/reconciler.go	Persists compiled AgentCardJSON into RuntimeRevision during reconciliation.
go/core/v2/a2agateway/gateway.go	Implements GetExtendedAgentCard by loading the pinned runtime_revision.agent_card and overlaying gateway-owned fields.
go/core/v2/a2agateway/gateway_test.go	Adds coverage ensuring the gateway serves template metadata from the pinned revision and uses the public gateway URL.
go/core/pkg/migrations/core/000013_runtime_revision_agent_card.up.sql	Adds agent_card JSONB column to runtime_revision.
go/core/pkg/migrations/core/000013_runtime_revision_agent_card.down.sql	Drops the agent_card column.
go/core/internal/database/queries/runtime_revisions.sql	Extends runtime revision upsert to include agent_card.
go/core/internal/database/gen/runtime_revisions.sql.go	Regenerates SQLC code to read/write agent_card.
go/core/internal/database/gen/models.go	Adds AgentCard []byte to SQLC RuntimeRevision model.
go/core/internal/database/gen/agent_instances.sql.go	Includes agent_card when selecting latest runtime revision for an instance.
go/core/internal/database/client_postgres.go	Maps AgentCard between API model and SQLC params/rows.
go/core/internal/database/client_agent_instance_test.go	Verifies AgentCard is persisted and retrievable from GetRuntimeRevision.
go/core/cmd/controller-v2/main.go	Wires A2A_GATEWAY_URL env var into the gateway constructor.
go/api/database/models.go	Adds AgentCard to the shared RuntimeRevision API model.

Files not reviewed (3)

• go/core/internal/database/gen/agent_instances.sql.go: Generated file
• go/core/internal/database/gen/models.go: Generated file
• go/core/internal/database/gen/runtime_revisions.sql.go: Generated file

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.